Remove unused JobScheduler from BlockCache config

Summary: Not used, no need to pass it in

Reviewed By: AlnisM

Differential Revision: D87248436

fbshipit-source-id: 6c940696adb229f3268f84f6350a84d35b8b4743

Author: Rob Lyerly

cachelib/navy/Factory.cpp

@@ -139,10 +139,8 @@ class BlockCacheProtoImpl final : public BlockCacheProto {
     config_.legacyEventTracker = legacyEventTracker;
   }
 
-  std::unique_ptr<Engine> create(JobScheduler& scheduler,
-                                 ExpiredCheck checkExpired,
+  std::unique_ptr<Engine> create(ExpiredCheck checkExpired,
                                  DestructorCallback cb) && {
-    config_.scheduler = &scheduler;
     config_.checkExpired = std::move(checkExpired);
     config_.destructorCb = std::move(cb);
     return std::make_unique<BlockCache>(std::move(config_));
@@ -243,7 +241,7 @@ class EnginePairProtoImpl final : public EnginePairProto {
       if (bcProto != nullptr) {
         bcProto->setDevice(device);
         bcProto->setPersistParams(persistParams);
-        bc = std::move(*bcProto).create(scheduler, checkExpired, destructorCb);
+        bc = std::move(*bcProto).create(checkExpired, destructorCb);
       }
     }
 

cachelib/navy/block_cache/BlockCache.cpp

@@ -32,7 +32,6 @@
 namespace facebook::cachelib::navy {
 
 BlockCache::Config& BlockCache::Config::validate() {
-  XDCHECK_NE(scheduler, nullptr);
   if (!device || !evictionPolicy) {
     throw std::invalid_argument("missing required param");
   }

cachelib/navy/block_cache/BlockCache.h

@@ -58,8 +58,6 @@ class BlockCache final : public Engine {
     uint64_t regionSize{16 * 1024 * 1024};
     // See AbstractCacheProto::setReadBufferSize
     uint32_t readBufferSize{};
-    // Job scheduler for background tasks
-    JobScheduler* scheduler{};
     // Clean region pool size
     uint32_t cleanRegionsPool{1};
     // The number of region_manager threads for reclaim and flush