Skip to content

Commit 9473508

Browse files
slorberJosh-Cena
andauthored
refactor(theme-common): split package into public/internal API entrypoints (#7660)
* add theme-common/internal export * Split @docusaurus/theme-common into public/internal apis * fixes * public <-> private * public <-> private * public <-> private * fix * add "removeThemeInternalReexport" CI script * :s windows CI check not working: not that useful * remove bad import * refactors * reorder * make useBackToTopButton internal Co-authored-by: Joshua Chen <[email protected]>
1 parent 35d320f commit 9473508

File tree

59 files changed

+276
-202
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

59 files changed

+276
-202
lines changed

.eslintrc.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -451,6 +451,7 @@ module.exports = {
451451
'admin/**',
452452
'jest/**',
453453
'website/**',
454+
'packages/docusaurus-theme-common/removeThemeInternalReexport.mjs',
454455
'packages/docusaurus-theme-translations/update.mjs',
455456
'packages/docusaurus-theme-translations/src/utils.ts',
456457
],

.github/workflows/tests.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,3 +40,7 @@ jobs:
4040
run: yarn test
4141
- name: TypeCheck website
4242
run: yarn workspace website typecheck
43+
- name: Remove Theme Internal Re-export
44+
run: yarn workspace @docusaurus/theme-common removeThemeInternalReexport
45+
- name: Docusaurus Build
46+
run: yarn build:website:fast

packages/docusaurus-theme-classic/src/theme-classic.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1103,7 +1103,7 @@ declare module '@theme/TOCItems' {
11031103
}
11041104

11051105
declare module '@theme/TOCItems/Tree' {
1106-
import type {TOCTreeNode} from '@docusaurus/theme-common';
1106+
import type {TOCTreeNode} from '@docusaurus/theme-common/internal';
11071107

11081108
export interface Props {
11091109
readonly toc: readonly TOCTreeNode[];

packages/docusaurus-theme-classic/src/theme/AnnouncementBar/index.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77

88
import React from 'react';
99
import clsx from 'clsx';
10-
import {useThemeConfig, useAnnouncementBar} from '@docusaurus/theme-common';
10+
import {useThemeConfig} from '@docusaurus/theme-common';
11+
import {useAnnouncementBar} from '@docusaurus/theme-common/internal';
1112
import {translate} from '@docusaurus/Translate';
1213
import IconClose from '@theme/IconClose';
1314

packages/docusaurus-theme-classic/src/theme/BackToTopButton/index.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@
88
import React from 'react';
99
import clsx from 'clsx';
1010
import {translate} from '@docusaurus/Translate';
11-
import {ThemeClassNames, useBackToTopButton} from '@docusaurus/theme-common';
11+
import {ThemeClassNames} from '@docusaurus/theme-common';
12+
import {useBackToTopButton} from '@docusaurus/theme-common/internal';
1213

1314
import styles from './styles.module.css';
1415

packages/docusaurus-theme-classic/src/theme/CodeBlock/Container/index.tsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,8 @@
77

88
import React, {type ComponentProps} from 'react';
99
import clsx from 'clsx';
10-
import {
11-
usePrismTheme,
12-
getPrismCssVariables,
13-
ThemeClassNames,
14-
} from '@docusaurus/theme-common';
10+
import {ThemeClassNames, usePrismTheme} from '@docusaurus/theme-common';
11+
import {getPrismCssVariables} from '@docusaurus/theme-common/internal';
1512
import styles from './styles.module.css';
1613

1714
export default function CodeBlockContainer<T extends 'div' | 'pre'>({

packages/docusaurus-theme-classic/src/theme/CodeBlock/Content/String.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,14 @@
77

88
import React from 'react';
99
import clsx from 'clsx';
10+
import {useThemeConfig, usePrismTheme} from '@docusaurus/theme-common';
1011
import {
11-
useThemeConfig,
1212
parseCodeBlockTitle,
1313
parseLanguage,
1414
parseLines,
1515
containsLineNumbers,
16-
usePrismTheme,
1716
useCodeWordWrap,
18-
} from '@docusaurus/theme-common';
17+
} from '@docusaurus/theme-common/internal';
1918
import Highlight, {defaultProps, type Language} from 'prism-react-renderer';
2019
import Line from '@theme/CodeBlock/Line';
2120
import CopyButton from '@theme/CodeBlock/CopyButton';

packages/docusaurus-theme-classic/src/theme/DocBreadcrumbs/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77

88
import React, {type ReactNode} from 'react';
99
import clsx from 'clsx';
10+
import {ThemeClassNames} from '@docusaurus/theme-common';
1011
import {
11-
ThemeClassNames,
1212
useSidebarBreadcrumbs,
1313
useHomePageRoute,
14-
} from '@docusaurus/theme-common';
14+
} from '@docusaurus/theme-common/internal';
1515
import Link from '@docusaurus/Link';
1616
import useBaseUrl from '@docusaurus/useBaseUrl';
1717
import {translate} from '@docusaurus/Translate';

packages/docusaurus-theme-classic/src/theme/DocCard/index.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,10 @@
88
import React, {type ReactNode} from 'react';
99
import clsx from 'clsx';
1010
import Link from '@docusaurus/Link';
11-
import {findFirstCategoryLink, useDocById} from '@docusaurus/theme-common';
11+
import {
12+
findFirstCategoryLink,
13+
useDocById,
14+
} from '@docusaurus/theme-common/internal';
1215
import isInternalUrl from '@docusaurus/isInternalUrl';
1316
import {translate} from '@docusaurus/Translate';
1417
import type {Props} from '@theme/DocCard';

packages/docusaurus-theme-classic/src/theme/DocCardList/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import React from 'react';
99
import clsx from 'clsx';
10-
import {findFirstCategoryLink} from '@docusaurus/theme-common';
10+
import {findFirstCategoryLink} from '@docusaurus/theme-common/internal';
1111
import DocCard from '@theme/DocCard';
1212
import type {Props} from '@theme/DocCardList';
1313
import type {PropSidebarItem} from '@docusaurus/plugin-content-docs';

0 commit comments

Comments
 (0)