Add various missing includes #9633
Conversation
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D83144825. (Because this pull request was imported automatically, there will not be any future comments.) |
|
LGTM, could you rebase? Our CI doesn't like merging commits that are more than ~2 days old. |
mszabo-wikia
force-pushed
the
add-missing-includes
branch
from
1a9990e to
a53fedb
Compare
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
|
Done, thanks! |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D83144825. (Because this pull request was imported automatically, there will not be any future comments.) |
mszabo-wikia
force-pushed
the
add-missing-includes
branch
from
a53fedb to
682427e
Compare
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
mszabo-wikia
force-pushed
the
add-missing-includes
branch
from
682427e to
afcdb24
Compare
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
These were originally detected when I was compiling HHVM with clang and libstdc++, but it's generally good to include what you use without relying on another standard library header pulling them in.
mszabo-wikia
force-pushed
the
add-missing-includes
branch
from
afcdb24 to
9f02a3d
Compare
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
|
This pull request has been merged in 969c994. |
3 participants
These were originally detected when I was compiling HHVM with clang and libstdc++, but it's generally good to include what you use without relying on another standard library header pulling them in.