Skip to content

Commit 8622836

Browse files
czentgrmeta-codesync[bot]
authored andcommitted
build(ci): Use GCC14 for the adapters CI (#15307)
Summary: This PR changes the compiler used to compile Velox and the bundled dependencies from GCC12 to GCC14. The original dependencies are still built with GCC12. This is a first step to upgrading the Velox ecosystem to GCC14. Pull Request resolved: #15307 Reviewed By: jagill Differential Revision: D86110358 Pulled By: kevinwilfong fbshipit-source-id: 5550c509541663ebf2cc9e8b0f56461f14735181
1 parent 6bb5399 commit 8622836

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

.github/workflows/linux-build-base.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ jobs:
7171
cd /
7272
rm -rf /tmp/build # cleanup to avoid issues with disk space
7373
fi
74+
# Install GCC14 until it is also available in the dependency image.
75+
dnf install -y gcc-toolset-14
7476
7577
- uses: apache/infrastructure-actions/stash/restore@3354c1565d4b0e335b78a76aedd82153a9e144d4
7678
with:
@@ -86,8 +88,8 @@ jobs:
8688
MAKEFLAGS: NUM_THREADS=8 MAX_HIGH_MEM_JOBS=4 MAX_LINK_JOBS=4
8789
CUDA_ARCHITECTURES: 70
8890
CUDA_COMPILER: /usr/local/cuda-${CUDA_VERSION}/bin/nvcc
89-
# Set compiler to GCC 12
90-
CUDA_FLAGS: -ccbin /opt/rh/gcc-toolset-12/root/usr/bin
91+
# Set compiler to GCC 14
92+
CUDA_FLAGS: -ccbin /opt/rh/gcc-toolset-14/root/usr/bin
9193
run: |
9294
EXTRA_CMAKE_FLAGS=(
9395
"-DVELOX_ENABLE_BENCHMARKS=ON"
@@ -113,6 +115,7 @@ jobs:
113115
# Investigate issues with remote function service: Issue #13897
114116
EXTRA_CMAKE_FLAGS+=("-DVELOX_ENABLE_REMOTE_FUNCTIONS=ON")
115117
fi
118+
source /opt/rh/gcc-toolset-14/enable
116119
make release EXTRA_CMAKE_FLAGS="${EXTRA_CMAKE_FLAGS[*]}"
117120
118121
- name: Ccache after

scripts/setup-centos9.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ function install_build_prerequisites {
5656
dnf config-manager --set-enabled crb
5757
dnf update -y
5858
fi
59-
dnf_install autoconf automake ccache gcc-toolset-12 git libtool \
59+
dnf_install autoconf automake ccache gcc-toolset-12 gcc-toolset-14 git libtool \
6060
ninja-build python3-pip python3-devel wget which
6161

6262
install_uv

0 commit comments

Comments
 (0)