Commit 12d8a2d
committed
Fix FBX SDK linking errors on Linux for static builds
The io_marker_test was failing to link on Linux CI because the FBX SDK
static library requires zlib and libdl dependencies that weren't being
linked.
Changes:
- cmake/FindFbxSdk.cmake: Added ZLIB and libdl (via CMAKE_DL_LIBS) to
the Linux dependencies list. This fixes undefined references to zlib
functions (deflate, inflate, crc32, adler32) and libdl functions
(dlopen, dlclose, dlsym).
- cmake/momentum-config.cmake.in: Added conditional find_dependency for
FbxSdk when MOMENTUM_ENABLE_FBX_SAVING is enabled. This ensures
downstream projects can properly link against momentum when built with
FBX SDK support as static libraries.
- CMakeLists.txt: Added FindFbxSdk.cmake to the install command so the
finder module is available to downstream projects.
Fixes: https://github.com/facebookresearch/momentum/actions/runs/19022913829/job/54321176648?pr=7531 parent 2c71006 commit 12d8a2d
File tree
3 files changed
+9
-4
lines changed- cmake
3 files changed
+9
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
920 | 920 | | |
921 | 921 | | |
922 | 922 | | |
923 | | - | |
| 923 | + | |
924 | 924 | | |
925 | 925 | | |
926 | 926 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
90 | | - | |
91 | | - | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
92 | 93 | | |
93 | 94 | | |
94 | 95 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
39 | 43 | | |
40 | 44 | | |
41 | 45 | | |
| |||
0 commit comments