Skip to content

Commit 24bf3d6

Browse files
cdtwiggmeta-codesync[bot]
authored andcommitted
Fix for missing meshState update. (#777)
Summary: Pull Request resolved: #777 We weren't updating the meshState in the sequence_solver_function getError() function. This turned out to be a bit hard to catch because it only shows up as an issue if you are running the sequence solver with line search turned on. Reviewed By: cstollmeta Differential Revision: D86116253 fbshipit-source-id: a7b6cda036abc00dcd9eb0d772e5c11494e71dac
1 parent 663023e commit 24bf3d6

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

momentum/character_sequence_solver/sequence_solver_function.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,9 @@ double SequenceSolverFunctionT<T>::getError(const Eigen::VectorX<T>& parameters)
192192
// update the state according to the transformed parameters
193193
dispenso::parallel_for(0, nFrames, [&](size_t f) {
194194
states_[f].set(parameterTransform_.apply(frameParameters_[f]), character_.skeleton);
195+
if (needsMesh_) {
196+
meshStates_[f].update(frameParameters_[f], states_[f], character_);
197+
}
195198
});
196199

197200
// sum up error for all per-frame error functions

0 commit comments

Comments
 (0)