Skip to content

Commit 80abdd2

Browse files
cdtwiggfacebook-github-bot
authored andcommitted
Rename from_gltf_bytes to load_gltf_from_bytes (#567)
Summary: Pull Request resolved: #567 This was actually feedback when I first landed this function, but I never got around to it. However I recently noticed that there's a ton of inconsistency across these IO functions so let's unify them. This is the first in a series of changes to make IO function naming more consistent across pymomentum. The naming pattern we're following is: {action}_{format}[_{data_type}][_{source_type}], since this is the format most of the other functions use. Reviewed By: jeongseok-meta Differential Revision: D82386701 fbshipit-source-id: ad93adbf66bddf7a8de0656b66a53d44cf1b3237
1 parent 8fd6455 commit 80abdd2

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pymomentum/geometry/geometry_pybind.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ PYBIND11_MODULE(geometry, m) {
235235
// - load_model_definition_from_bytes(model_bytes)
236236
//
237237
// [static methods for io]
238-
// - from_gltf_bytes(gltf_btyes)
238+
// - load_gltf_from_bytes(gltf_btyes)
239239
// - to_gltf(character, fps, motion, offsets)
240240
// - load_fbx(fbxFilename, modelFilename, locatorsFilename)
241241
// - load_fbx_from_bytes(fbx_bytes, permissive)
@@ -668,7 +668,7 @@ Note that not all parameters will have limits; for those parameters (such as glo
668668
669669
Note: In practice, most limits are enforced on the model parameters, but momentum's joint limit functionality permits applying limits to joint parameters also as a conveninence. )")
670670
.def_static(
671-
"from_gltf_bytes",
671+
"load_gltf_from_bytes",
672672
&loadGLTFCharacterFromBytes,
673673
py::call_guard<py::gil_scoped_release>(),
674674
R"(Load a character from a gltf byte array.

0 commit comments

Comments
 (0)