refactor(userspace): Make Cflags in our .pc files more strict

Remove "-I${includedir}/libscap -I${includedir}/driver" from libscap.pc
and libsinsp.pc. This means that consumers must use prefixed include
paths, such as "#include <libscap/scap.h>" instead of "#include
<scap.h>". However, those include directories contain several generic
filenames such as settings.h, logger.h, plugin.h, user.h, and utils.h,
and this reduces the risk of someone inadvertently including the wrong
file.

Signed-off-by: Gerald Combs <[email protected]>

Author: geraldcombs

userspace/libscap/libscap.pc.in

@@ -9,4 +9,4 @@ Version: @FALCOSECURITY_LIBS_VERSION@
 Requires: @LIBSCAP_PKGCONFIG_REQUIRES@
 Requires.private: @LIBSCAP_PKGCONFIG_REQUIRES_PRIVATE@
 Libs: -L${libdir} @LIBSCAP_LINK_LIBDIRS_FLAGS@ @LIBSCAP_LINK_LIBRARIES_FLAGS@
-Cflags: -I${includedir} -I${includedir}/libscap -I${includedir}/driver
+Cflags: -I${includedir}

userspace/libsinsp/fdinfo.h

@@ -25,7 +25,7 @@ limitations under the License.
 
 #include <unordered_map>
 #include <memory>
-#include <packed_data.h>
+#include <libsinsp/packed_data.h>
 
 // fd type characters
 #define CHAR_FD_FILE 'f'

userspace/libsinsp/libsinsp.pc.in

@@ -9,4 +9,4 @@ Version: @FALCOSECURITY_LIBS_VERSION@
 Requires: libscap @LIBSINSP_REQUIRES@
 Requires.private: @LIBSINSP_REQUIRES_PRIVATE@
 Libs: -L${libdir} @SINSP_PKG_CONFIG_LIBDIRS@ @SINSP_PKG_CONFIG_LIBS@
-Cflags: -I${includedir} -I${includedir}/libsinsp -I${includedir}/driver @SINSP_PKG_CONFIG_INCLUDES@
+Cflags: -I${includedir} @SINSP_PKG_CONFIG_INCLUDES@

userspace/libsinsp/threadinfo.h

@@ -31,7 +31,7 @@ struct iovec {
 
 #include <functional>
 #include <memory>
-#include <sinsp_fdtable_factory.h>
+#include <libsinsp/sinsp_fdtable_factory.h>
 #include <libsinsp/fdtable.h>
 #include <libsinsp/thread_group_info.h>
 #include <libsinsp/state/table.h>