Makes input boxes of search plugin work better on mobile #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the input boxes of the search plugin work better on mobile. Changing the input type to "search" makes it so that the virtual keyboard that pops up on mobile devices has a search button where the enter key normally is, so that clicking in will execute the search. Currently, with the type set to "text", the enter button on mobile keyboards is changed into a tab, because the browser sees, the input box for the search in the wiki footer, and thinks the user might want to tab over there instead of executing the search.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the input boxes of the search plugin work better on mobile. Changing the input type to "search" makes it so that the virtual keyboard that pops up on mobile devices has a search button where the enter key normally is, so that clicking it will execute the search. Currently, with the type set to "text", the enter button on mobile keyboards is changed into a tab button, because the browser sees, the input box for the search in the wiki footer, and thinks the user might want to tab over there instead of executing the search. (i.e. I can't execute the search at all on my mobile phone.)