Theme clean-up and better API 8, 9 and 10 support #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 30, 2015 12:03
…ons; - Added default android:windowWidthMajor and android:windowWidthMinor values (the default android values may vary per device and Android version); - Added back-ported support for windowWidthMajor and windowWidthMinor for android API 8, 9 and 10; - Theme clean-up;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cleaned the AlertDialogPro themes and back-ported the windowMinWidthMajor and windowMinWidthMinor attributes for API 8, 9 and 10 just like AppCompat version 22.1.X does. The only difference is that the android:windowMinWidthMajor and android:windowMinWidthMinor should still be used for API 11 and above, this is not the case in the AppCompat AlertDialog implementation, in AppCompat the windowMinWidthMajor and windowMinWidthMinor attributes do work for API 11 and above.
I also added the default values (default, large and xlarge) for windowMinWidthMajor and windowMinWidthMinor because they can vary across different Android versions, custom roms and sometimes even manufactures.
Tested on multiple devices, emulators and Android versions. Also my app Tinycore will receive an update today with these changes implemented, so that will be the big test ;)