-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
Describe the bug
There are slow memory leak due to refc binaries accumulating over large file transfers (large files, with large file counts, in the hundreds to many thousands).
It's not a major thing, but memory usage is easy to spot when running the recon calls for it and looking at the results.
To Reproduce
([email protected])2> recon:bin_leak(5).
[{<0.1278.0>,-950,
[{current_function,{gen_server,loop,7}},
{initial_call,{proc_lib,init_p,5}}]},
{<0.1302.0>,-867,
[{current_function,{gen_server,loop,7}},
{initial_call,{proc_lib,init_p,5}}]},
{<0.1288.0>,-647,
[{current_function,{gen_server,loop,7}},
{initial_call,{proc_lib,init_p,5}}]},
{<0.1280.0>,-497,
[{current_function,{gen_server,loop,7}},
{initial_call,{proc_lib,init_p,5}}]},
{<0.1206.0>,-414,
[ssl_manager,
{current_function,{gen_server,loop,7}},
{initial_call,{proc_lib,init_p,5}}]}]
Expected behavior
It would probably be worth it for revault_fsm and its related network transfer workers to run a hibernation from time to time (eg. after a whole sync and after having sync'd file over size N or M files in a row)
Environment:
- OS:
Linux raspberrypi.local 6.6.31+rpt-rpi-v8 #1 SMP PREEMPT Debian 1:6.6.31-1+rpt1 (2024-05-29) aarch64 GNU/LinuxDarwin airm1.local 24.0.0 Darwin Kernel Version 24.0.0: Tue Sep 24 23:36:26 PDT 2024; root:xnu-11215.1.12~1/RELEASE_ARM64_T8103 arm64
- Erlang Version: OTP-27.1.1
- ReVault Release Version: 42b020a
Additional context
This did not cause any actual problem, but I assume over extended time periods it could create system pressure.
Temporary Workaround
- run the recon gc by hand
- if it dies, quit and restart, which will resume transfers for all remaining files.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers