runtime: remove fd_directly_invoke_loader_v3_deploy

Author: riptl

src/flamenco/runtime/fd_core_bpf_migration.c

@@ -372,15 +372,7 @@ migrate_builtin_to_core_bpf1( fd_core_bpf_migration_config_t const * config,
   }
 
   assert( new_target_program_data->data_sz>=PROGRAMDATA_METADATA_SIZE );
-  if( FD_UNLIKELY( !fd_directly_invoke_loader_v3_deploy(
-      bank,
-      funk,
-      funk->shmem,
-      &target->program_account->addr,
-      new_target_program_data->data   +PROGRAMDATA_METADATA_SIZE,
-      new_target_program_data->data_sz-PROGRAMDATA_METADATA_SIZE ) ) ) {
-    return;
-  }
+  /* FIXME call fd_directly_invoke_loader_v3_deploy */
 
   ulong lamports_to_burn;
   if( FD_UNLIKELY( __builtin_uaddl_overflow(

src/flamenco/runtime/program/fd_bpf_loader_program.c

@@ -2569,74 +2569,3 @@ fd_bpf_loader_program_execute( fd_exec_instr_ctx_t * ctx ) {
 
   return fd_bpf_execute( ctx, cache_entry, is_deprecated );
 }
-
-
-/* Public APIs */
-
-int
-fd_directly_invoke_loader_v3_deploy( fd_bank_t *         bank,
-                                     fd_funk_t *         funk,
-                                     void *              accdb_shfunk,
-                                     fd_pubkey_t const * program_key,
-                                     uchar const *       elf,
-                                     ulong               elf_sz ) {
-  FD_LOG_ERR(( "fd_directly_invoke_loader_v3_deploy is not implemented" ));
-
-  (void)bank;
-  (void)funk;
-  (void)accdb_shfunk;
-  (void)program_key;
-  (void)elf;
-  (void)elf_sz;
-
-  // /* Set up a dummy instr and txn context.
-  //    FIXME: Memory for a txn context needs to be allocated */
-  // fd_exec_txn_ctx_t * txn_ctx = fd_exec_txn_ctx_join( fd_exec_txn_ctx_new( NULL ) );
-
-  // if( FD_UNLIKELY( !fd_funk_join( funk, accdb_shfunk ) ) ) {
-  //   FD_LOG_CRIT(( "fd_funk_join(accdb) failed" ));
-  // }
-  // txn_ctx->bank_hash_cmp             = NULL;
-  // txn_ctx->log.enable_exec_recording = !!(bank->flags & FD_BANK_FLAGS_EXEC_RECORDING);
-  // txn_ctx->bank                      = bank;
-
-  // fd_txn_out_t txn_out;
-  // fd_compute_budget_details_new( &txn_out.details.compute_budget );
-  // txn_out.accounts.accounts_cnt     = 0UL;
-  // txn_out.accounts.executable_cnt   = 0UL;
-
-  // txn_out.details.programs_to_reverify_cnt       = 0UL;
-  // txn_out.details.loaded_accounts_data_size      = 0UL;
-  // txn_out.details.loaded_accounts_data_size_cost = 0UL;
-  // txn_out.details.accounts_resize_delta          = 0UL;
-
-  // memset( txn_out.details.return_data.program_id.key, 0, sizeof(fd_pubkey_t) );
-  // txn_out.details.return_data.len = 0;
-
-  // txn_ctx->log.capture_ctx   = NULL;
-
-  // txn_ctx->instr.info_cnt     = 0UL;
-  // txn_ctx->instr.trace_length = 0UL;
-
-  // txn_out.err.exec_err          = 0;
-  // txn_out.err.exec_err_kind     = FD_EXECUTOR_ERR_KIND_NONE;
-  // txn_ctx->instr.current_idx = 0;
-
-  // txn_ctx->instr.stack_sz = 1;
-  // fd_exec_instr_ctx_t * instr_ctx = &txn_ctx->instr.stack[0];
-  // *instr_ctx = (fd_exec_instr_ctx_t) {
-  //   .instr     = NULL,
-  //   .txn_ctx   = txn_ctx,
-  //   .txn_out   = &txn_out,
-  // };
-
-  /* Important note: this function is called at the epoch boundary and
-     does not do anything with the `programs_to_reverify` field in the
-     transaction context. This is fine though because when this function
-     is called, the program will not exist in the cache yet (because it
-     does not exist on-chain as a BPF program yet). There is no queueing
-     needed because the next time the program is invoked, the program
-     cache updating logic will see that the cache entry is missing and
-     will insert it then. */
-  // return fd_deploy_program( instr_ctx, program_key, elf, elf_sz );
-}

src/flamenco/runtime/program/fd_bpf_loader_program.h

@@ -76,28 +76,6 @@ fd_bpf_execute( fd_exec_instr_ctx_t *      instr_ctx,
 int
 fd_bpf_loader_program_execute( fd_exec_instr_ctx_t * instr_ctx );
 
-/* Public APIs */
-
-/* This function is called from `fd_runtime.c` and only performs the ELF
-   and VM validation checks necessary to deploy a program, specifically
-   for the core native program BPF migration. Since this call is done at
-   the epoch boundary every time a new BPF core migration feature is
-   activated, we need to mock up a transaction and instruction context
-   for execution.  We do not do any funk operations here - instead, the
-   BPF cache entry will be created at the end of the block.  Because of
-   this, our logic is slightly different than Agave's.  See the
-   documentation for our `fd_deploy_program` for more information.
-
-   https://github.com/anza-xyz/agave/blob/v2.1.0/runtime/src/bank/builtins/core_bpf_migration/mod.rs#L155-L233 */
-
-int
-fd_directly_invoke_loader_v3_deploy( fd_bank_t *         bank,
-                                     fd_funk_t *         funk,
-                                     void *              accdb_shfunk,
-                                     fd_pubkey_t const * program_key,
-                                     uchar const *       elf,
-                                     ulong               elf_sz );
-
 FD_PROTOTYPES_END
 
 #endif /* HEADER_fd_src_flamenco_runtime_program_fd_bpf_loader_program_h */