fix(incident): satisfy golangci-lint and stop pinning verification prose in tests

Two issues found in review, both against the same code:

1. golangci-lint (default set, staticcheck ST1005) flags the verification
   error for ending in punctuation. Extract the shared guidance sentence and
   the per-incident "not found" detail into named constants
   (commentVerificationGuidance, commentVerificationNotFoundDetailFmt) and
   drop the trailing period, matching this repo's existing convention for
   multi-sentence errors (args.go, root.go): internal periods are fine, a
   trailing one is not.

2. That extraction also fixes a test-design problem: the transport-error and
   not-found tests were each asserting a hand-copied fragment of the
   guidance sentence, so editing the prose in one place silently broke tests
   elsewhere — exactly what happened moving from "do not retry this command
   against the full batch" to "Do not write the comment again" earlier in
   this branch. Both tests now assert against the same
   commentVerificationGuidance symbol the production code emits, so a future
   reword of the constant keeps every caller in sync automatically instead of
   requiring a hunt for hand-duplicated copies. Also strengthened the
   transport-error test to assert the passing incident is NOT named as a
   problem, mirroring the batch test's coverage.

Verified against golangci-lint v2.11.0 (matching .github/workflows/lint.yml
exactly, not just whatever was already on PATH): 0 issues.

Author: ysyneu

internal/cli/command_test.go

@@ -765,14 +765,17 @@ func TestCommandIncidentCommentFailsWhenTextNotFoundWithinBudget(t *testing.T) {
 	if err == nil {
 		t.Fatal("[not-found] expected a non-zero exit, got nil error")
 	}
-	if !strings.Contains(err.Error(), "no timeline entry matches the written text") {
-		t.Fatalf("[not-found] unexpected error: %v", err)
+	if !strings.Contains(err.Error(), "inc-1") {
+		t.Fatalf("[not-found] expected the failing incident named in the error: %v", err)
 	}
 	if strings.Contains(err.Error(), "corrupted") {
 		t.Fatalf("[not-found] must not claim corruption it has not established: %v", err)
 	}
-	if !strings.Contains(err.Error(), "Do not write the comment again") {
-		t.Fatalf("[not-found] must warn against rewriting, at any granularity: %v", err)
+	// Asserted against the same commentVerificationGuidance symbol the
+	// production code emits, not a hand-copied fragment of it — a prose
+	// rewording of the constant keeps this test green automatically.
+	if !strings.Contains(err.Error(), commentVerificationGuidance) {
+		t.Fatalf("[not-found] must carry the standard verification guidance: %v", err)
 	}
 	if strings.Contains(out, "Commented on") {
 		t.Fatalf("[not-found] must not report success:\n%s", out)
@@ -793,7 +796,7 @@ func TestCommandIncidentCommentFailsWhenNoCommentEntryFound(t *testing.T) {
 	if err == nil {
 		t.Fatal("[readback-missing] expected a non-zero exit, got nil error")
 	}
-	if !strings.Contains(err.Error(), "no timeline entry matches the written text") {
+	if !strings.Contains(err.Error(), fmt.Sprintf(commentVerificationNotFoundDetailFmt, maxIncidentFeedVerifyPages)) {
 		t.Fatalf("[readback-missing] unexpected error: %v", err)
 	}
 	if strings.Contains(out, "Commented on") {
@@ -908,10 +911,17 @@ func TestCommandIncidentCommentTransportErrorCarriesAntiRetryWarning(t *testing.
 		t.Fatal("[transport-error] expected a non-zero exit, got nil error")
 	}
 	if !strings.Contains(err.Error(), "inc-1") {
-		t.Fatalf("[transport-error] expected inc-1 named in the error: %v", err)
+		t.Fatalf("[transport-error] expected the failing incident named in the error: %v", err)
 	}
-	if !strings.Contains(err.Error(), "Do not write the comment again") {
-		t.Fatalf("[transport-error] must carry the same anti-retry framing as the not-found case: %v", err)
+	if strings.Contains(err.Error(), "inc-2") {
+		t.Fatalf("[transport-error] inc-2 verified fine and must not be named as a problem: %v", err)
+	}
+	// Asserted against the same commentVerificationGuidance symbol
+	// TestCommandIncidentCommentFailsWhenTextNotFoundWithinBudget checks,
+	// proving both failure branches share identical guidance by construction
+	// rather than by two independently maintained prose copies.
+	if !strings.Contains(err.Error(), commentVerificationGuidance) {
+		t.Fatalf("[transport-error] must carry the same guidance as the not-found case: %v", err)
 	}
 	if strings.Contains(err.Error(), "corrupted") {
 		t.Fatalf("[transport-error] must not claim corruption: %v", err)

internal/cli/incident.go

@@ -948,6 +948,24 @@ func resolveCommentFile(path string) (string, error) {
 // headroom for any real incident, and only bounds a pathological one.
 const maxIncidentFeedVerifyPages = 20
 
+// commentVerificationGuidance is appended, verbatim, to every comment
+// verification failure — whether the entry simply couldn't be located (page
+// budget) or the re-fetch itself errored (transport failure). Both are
+// "could not confirm," never "confirmed missing," so both carry the
+// identical instruction. It is a named constant, not inline prose duplicated
+// at each call site, specifically so a test can assert against this exact
+// symbol instead of pinning a copy of the sentence: reword this constant and
+// every caller (production and test) picks up the new wording automatically,
+// with nothing left to fall out of sync.
+const commentVerificationGuidance = "The write API already reported success for the whole batch (a single POST covering every requested incident), and not finding a match here does not mean a comment is missing — this check can only confirm presence, never confirm absence. Do not write the comment again, for the full batch or for the incident(s) listed above alone: either risks a duplicate on a write that most likely already landed. Run `fduty incident timeline <id>` on the listed incident(s) to check by hand before deciding on anything further"
+
+// commentVerificationNotFoundDetailFmt is the per-incident detail appended to
+// commentVerificationGuidance's problem list when the page walk completes
+// without finding a match, formatted with maxIncidentFeedVerifyPages. Also a
+// named symbol rather than inline prose, for the same reason as
+// commentVerificationGuidance above.
+const commentVerificationNotFoundDetailFmt = "no timeline entry matches the written text within the first %d pages"
+
 // verifyIncidentCommentsWritten re-fetches every incident's timeline after a
 // comment write and confirms an entry with the exact text just sent is
 // present. The Comment API returns no handle for the created entry, so this
@@ -993,18 +1011,14 @@ func verifyIncidentCommentsWritten(ctx *RunContext, want string) error {
 		case err != nil:
 			problems = append(problems, fmt.Sprintf("incident %s: %v", id, err))
 		case !found:
-			problems = append(problems, fmt.Sprintf("incident %s: no timeline entry matches the written text within the first %d pages", id, maxIncidentFeedVerifyPages))
+			problems = append(problems, fmt.Sprintf("incident %s: "+commentVerificationNotFoundDetailFmt, id, maxIncidentFeedVerifyPages))
 		}
 	}
 	if len(problems) == 0 {
 		return nil
 	}
-	return fmt.Errorf(
-		"comment verification could not confirm %d of %d incident(s) — %s. "+
-			"The write API already reported success for all %d incident(s) in this batch (a single POST covering the whole list), and not finding a match here does not mean a comment is missing — this check can only confirm presence, never confirm absence. "+
-			"Do not write the comment again, for the full batch or for the incident(s) listed above alone: either risks a duplicate on a write that most likely already landed. "+
-			"Run `fduty incident timeline <id>` on the listed incident(s) to check by hand before deciding on anything further.",
-		len(problems), len(ctx.Args), strings.Join(problems, "; "), len(ctx.Args))
+	return fmt.Errorf("comment verification could not confirm %d of %d incident(s) — %s. %s",
+		len(problems), len(ctx.Args), strings.Join(problems, "; "), commentVerificationGuidance)
 }
 
 // incidentTimelineHasComment walks every page of incidentID's i_comm feed