Skip to content

Commit 7053d7b

Browse files
committed
fix(skills): monit cards invoked four nonexistent tools
`monit-agent.md` ran `host.top` / `host.disk` and `monit.md` ran `host.cpu` / `host.mem`. None of the four exist. monit-agent v0.0.7 registers exactly: host → os.overview, os.top_processes, net.tcp_ping, http.get, shell.exec; mysql → mysql.overview, mysql.lock_contention, mysql.query. An agent copying these gets `unknown_tool`, and the `host.top` example also passed `limit`, which is not a parameter of anything (`os.top_processes` takes `top_n` / `sort_by`, and the agent validates with `additionalProperties:false`, so a wrong key is a hard `invalid_args`, not a silent no-op). The generated help in this repo (zz_generated_diagnostics.go, zz_generated_response_help.go) was already correct — only these hand-written cards drifted, because nothing checks their JSON bodies against the registry. Replacements verified live against a real dev target. Deliberately kept separate from the SDK-bump branch so it can land without waiting on that.
1 parent d1e052f commit 7053d7b

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

skills/flashduty/reference/monit-agent.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Prereq: `SKILL.md` read. On-box diagnostics: run diagnostic tools on a host or d
2020
fduty monit-agent catalog --target-locator <host-or-instance> --output-format toon
2121
# 2. invoke up to 8 tools concurrently; tool names taken verbatim from the catalog
2222
fduty monit-agent invoke --target-locator <host-or-instance> \
23-
--data '{"tools":[{"tool":"host.top","params":{}},{"tool":"host.disk","params":{}}]}'
23+
--data '{"tools":[{"tool":"os.overview"},{"tool":"os.top_processes","params":{"top_n":10}}]}'
2424
```
2525

2626
<!-- GENERATED:monit-agent START · 由 fduty __dump-commands 同步 · 勿手改 fence 内 -->
@@ -60,6 +60,6 @@ Run up to 8 monit-agent tools concurrently on a target
6060
6161
```bash
6262
fduty monit-agent invoke --target-locator web-prod-3 \
63-
--data '{"tools":[{"tool":"host.top","params":{"limit":10}},{"tool":"host.disk","params":{}}]}' \
63+
--data '{"tools":[{"tool":"os.overview"},{"tool":"os.top_processes","params":{"top_n":10}}]}' \
6464
--output-format toon
6565
```

skills/flashduty/reference/monit.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ fduty monit tools-catalog --target-locator <hostname-or-ip> --output-format toon
6565

6666
# 3. invoke tools (up to 8 concurrently); use heredoc to avoid shell quoting hell
6767
fduty monit tools-invoke --target-locator <hostname-or-ip> --output-format toon --data - <<'EOF'
68-
{"tools":[{"tool":"host.cpu","params":{}},{"tool":"host.mem","params":{}}]}
68+
{"tools":[{"tool":"os.overview"},{"tool":"os.top_processes","params":{"top_n":10}}]}
6969
EOF
7070
```
7171

0 commit comments

Comments
 (0)