feat: sync with go-flashduty v0.14.4 (corrected OpenAPI surface)

- Bump go-flashduty to v0.14.4 and regenerate all commands.
- Downloads are real now: operations returning a bounded binary body
  (CSV exports, enrichment mapping download, RUM issue export) generate
  commands that stream Response.Raw, so 'fduty insight channel-export >
  out.csv' works. cligen's streaming exclusion now covers only ndjson
  streams, matching the SDK generator.
- Multipart uploads are curated: 'enrichment mapping-data-upload' and
  'safari skill-upload' take --file (path or -) and ride the SDK's
  hand-written upload methods. The previously generated upload command
  could not send a file at all.
- cligen renders nullable union types ([T, null]) by their non-null
  member at every classification site (new typeStr helper); nullable
  arrays previously showed as 'any' and their children never expanded.
- Add claimStdin so --file - keeps the single-consumer stdin guard.
- Retire the retiredOperationIDs bridge: the linked spec no longer
  carries those operations.
- Fix curated call sites for the corrected SDK types (pointer time
  filters, nullable group name, MCP server item without tools).

Author: ysyneu

go.mod

@@ -3,7 +3,7 @@ module github.com/flashcatcloud/flashduty-cli
 go 1.25.1
 
 require (
-	github.com/flashcatcloud/go-flashduty v0.14.2
+	github.com/flashcatcloud/go-flashduty v0.14.4
 	github.com/mattn/go-runewidth v0.0.28
 	github.com/spf13/cobra v1.10.2
 	github.com/spf13/pflag v1.0.10

go.sum

@@ -1,8 +1,8 @@
 github.com/clipperhouse/uax29/v2 v2.2.0 h1:ChwIKnQN3kcZteTXMgb1wztSgaU+ZemkgWdohwgs8tY=
 github.com/clipperhouse/uax29/v2 v2.2.0/go.mod h1:EFJ2TJMRUaplDxHKj1qAEhCtQPW2tJSwu5BF98AuoVM=
 github.com/cpuguy83/go-md2man/v2 v2.0.6/go.mod h1:oOW0eioCTA6cOiMLiUPZOpcVxMig6NIQQ7OS05n1F4g=
-github.com/flashcatcloud/go-flashduty v0.14.2 h1:SIF8AMoaF67eEGAiiq8e4y5Dvv/0OOA/VzoxYpDB1CE=
-github.com/flashcatcloud/go-flashduty v0.14.2/go.mod h1:aA0RtZEs0AYOwwdNKdtVeD8YMOdnmVY1zAlVD+9Ovx8=
+github.com/flashcatcloud/go-flashduty v0.14.4 h1:b+Hrkt631lP41o5M4fqxgLZPGd85CHvCnch1qv3Dj+E=
+github.com/flashcatcloud/go-flashduty v0.14.4/go.mod h1:YpHiTYXR5NXBI/rGRZfUy537XMkhdCkwA8NW1QoRHwk=
 github.com/inconshreveable/mousetrap v1.1.0 h1:wN+x4NVGpMsO7ErUn/mUI3vEoE6Jt13X2s0bqwp9tc8=
 github.com/inconshreveable/mousetrap v1.1.0/go.mod h1:vpF70FUmC8bwa3OWnCshd2FqLfsEA9PFc4w1p2J65bw=
 github.com/mattn/go-runewidth v0.0.28 h1:rPyg2ybwEKPebvpzVWe1gKBkH8EQFkxO4Y0hjBeLaBU=

internal/cli/alert_event.go

@@ -41,8 +41,8 @@ func newAlertEventListCmd() *cobra.Command {
 				}
 
 				input := &flashduty.AlertEventGlobalListRequest{
-					StartTime: startTime,
-					EndTime:   endTime,
+					StartTime: flashduty.Int64(startTime),
+					EndTime:   flashduty.Int64(endTime),
 				}
 				input.Limit = limit
 				input.Page = page

internal/cli/coverage_test.go

@@ -15,29 +15,27 @@ import (
 type specOpMeta struct {
 	id        string
 	path      string
-	streaming bool // 200 body is not application/json (e.g. application/x-ndjson)
+	streaming bool // 200 body is application/x-ndjson with no JSON variant
 }
 
 var curatedOperationIDs = map[string]bool{
 	// Uses a path parameter plus bearer trigger token instead of the app_key
 	// generated command runtime. Served by a hand-written path command.
 	"automation-trigger-write-fire": true,
-}
-
-// retiredOperationIDs bridges the release window where the server-side route
-// is gone but the CLI still compiles against the previous released SDK spec.
-var retiredOperationIDs = map[string]bool{
-	"monit-preview-sync":      true,
-	"monit-read-query-rows":   true,
-	"monit-rule-write-status": true,
+	// Multipart/form-data file uploads cannot be assembled from --data/flags;
+	// both are served by curated commands built on the hand-written SDK
+	// upload methods (see upload.go).
+	"mapping-data-write-upload": true,
+	"skill-write-upload":        true,
 }
 
 // loadSpecOps reads every public GET/POST operation from the openapi spec
 // shipped in the linked go-flashduty module — the same spec cligen generates
-// against — recording each op's id, path, and whether its 200 response is a
-// non-JSON streaming body. Streaming ops are served by curated commands (the
-// generated typed-response template cannot model an io.ReadCloser), so the
-// generator-coverage check excludes them.
+// against — recording each op's id, path, and whether its 200 response is an
+// ndjson stream. Streaming ops are served by curated commands (the generated
+// typed-response template cannot model an io.ReadCloser), so the
+// generator-coverage check excludes them. Bounded binary downloads (csv,
+// octet-stream) are NOT streams: the generated command streams Response.Raw.
 func loadSpecOps(t *testing.T) []specOpMeta {
 	t.Helper()
 	out, err := exec.Command("go", "list", "-m", "-f", "{{.Dir}}", "github.com/flashcatcloud/go-flashduty").Output()
@@ -73,29 +71,16 @@ func loadSpecOps(t *testing.T) []specOpMeta {
 			}
 			streaming := false
 			if resp, ok := op.Responses["200"]; ok && len(resp.Content) > 0 {
-				if _, hasJSON := resp.Content["application/json"]; !hasJSON {
-					streaming = true
-				}
+				_, hasJSON := resp.Content["application/json"]
+				_, hasNDJSON := resp.Content["application/x-ndjson"]
+				streaming = !hasJSON && hasNDJSON
 			}
 			ops = append(ops, specOpMeta{id: op.OperationID, path: path, streaming: streaming})
 		}
 	}
 	return ops
 }
 
-// loadSpecPaths returns operationId -> path for every public GET/POST operation.
-func loadSpecPaths(t *testing.T) map[string]string {
-	t.Helper()
-	ids := map[string]string{}
-	for _, op := range loadSpecOps(t) {
-		if retiredOperationIDs[op.id] {
-			continue
-		}
-		ids[op.id] = op.path
-	}
-	return ids
-}
-
 // pathCommand derives the path-is-king command for an API path: the first
 // segment is the group, the remaining segments hyphen-join into the verb. This
 // mirrors cligen's cliGroup/cliVerb (spec path segments are already kebab-case,
@@ -139,7 +124,10 @@ func leafCommandPaths() map[string]bool {
 // the operation without guessing — generated commands provide the path-name and
 // curated commands win the exact name when they already own it.
 func TestEveryOperationHasPathCommand(t *testing.T) {
-	specPaths := loadSpecPaths(t)
+	specPaths := map[string]string{}
+	for _, op := range loadSpecOps(t) {
+		specPaths[op.id] = op.path
+	}
 	leaves := leafCommandPaths()
 	var missing []string
 	for _, apiPath := range specPaths {
@@ -157,21 +145,18 @@ func TestEveryOperationHasPathCommand(t *testing.T) {
 
 // TestGeneratorTargetsFullSpec asserts the generator emitted a command for every
 // non-streaming spec operation (no gaps, no phantom manifest entries from a
-// stale run). Streaming ops (200 body is not application/json) are deliberately
+// stale run). Streaming ops (200 body is application/x-ndjson) are deliberately
 // excluded from generation — they cannot be modeled by the typed-response
 // template and are served by curated commands instead — so the manifest must NOT
 // contain them and they are not required to be generated. A small number of
 // non-streaming operations can also be curated when the generated app_key
-// runtime cannot model their auth or path shape.
+// runtime cannot model their auth, path, or multipart-body shape.
 func TestGeneratorTargetsFullSpec(t *testing.T) {
 	ops := loadSpecOps(t)
 	streaming := map[string]bool{}
 	curated := map[string]bool{}
 	wantGenerated := map[string]bool{}
 	for _, op := range ops {
-		if retiredOperationIDs[op.id] {
-			continue
-		}
 		if op.streaming {
 			streaming[op.id] = true
 			continue
@@ -186,13 +171,12 @@ func TestGeneratorTargetsFullSpec(t *testing.T) {
 	gen := map[string]bool{}
 	for _, id := range generatedOpIDs {
 		gen[id] = true
-		if streaming[id] {
+		switch {
+		case streaming[id]:
 			t.Errorf("manifest op %q is streaming and must not be generated (curated only)", id)
-		}
-		if curated[id] {
+		case curated[id]:
 			t.Errorf("manifest op %q is curated and must not be generated", id)
-		}
-		if !wantGenerated[id] && !streaming[id] && !curated[id] {
+		case !wantGenerated[id]:
 			t.Errorf("manifest op %q is not in the current spec (regenerate cligen)", id)
 		}
 	}

internal/cli/gen_support.go

@@ -31,21 +31,30 @@ var stdinReader io.Reader = os.Stdin
 // the conflict.
 var stdinConsumedBy string
 
+// claimStdin marks stdin as consumed by flag and returns the reader WITHOUT
+// reading it — for callers that stream (e.g. multipart upload), where
+// buffering the whole stream the way readStdin does would defeat the point.
+// The single-consumer rule is identical to readStdin's; both funnel through
+// this one claim site.
+func claimStdin(flag string) (io.Reader, error) {
+	if stdinConsumedBy != "" {
+		return nil, fmt.Errorf("only one flag can read from stdin: %s and %s were both set to \"-\"", stdinConsumedBy, flag)
+	}
+	stdinConsumedBy = flag
+	return stdinReader, nil
+}
+
 // readStdin is the single function through which every --*-file-style flag's
 // "-" value reads stdin. flag is the calling flag's canonical spelling (e.g.
 // "--data"), used only to label it in the already-consumed error below. A
 // second flag trying to read stdin after an earlier one already claimed it
 // errors instead of silently returning empty bytes.
 func readStdin(flag string) ([]byte, error) {
-	if stdinConsumedBy != "" {
-		return nil, fmt.Errorf("only one flag can read from stdin: %s and %s were both set to \"-\"", stdinConsumedBy, flag)
-	}
-	b, err := io.ReadAll(stdinReader)
+	r, err := claimStdin(flag)
 	if err != nil {
 		return nil, err
 	}
-	stdinConsumedBy = flag
-	return b, nil
+	return io.ReadAll(r)
 }
 
 // readPathOrStdin reads the raw bytes at path, or from stdin (via readStdin)

internal/cli/generic_table_test.go

@@ -144,7 +144,7 @@ func TestRenderGenericTable_DetailVertical(t *testing.T) {
 	}
 }
 
-func TestRenderGenericTable_McpServerItemWithEmptyToolsRendersDetail(t *testing.T) {
+func TestRenderGenericTable_McpServerItemRendersDetail(t *testing.T) {
 	var buf bytes.Buffer
 	item := &flashduty.McpServerItem{
 		ServerID:    "mcp_test",
@@ -154,14 +154,13 @@ func TestRenderGenericTable_McpServerItemWithEmptyToolsRendersDetail(t *testing.
 		Status:      "enabled",
 		Transport:   "streamable-http",
 		URL:         "https://mcp.example.com/github",
-		Tools:       []flashduty.McpToolInfo{},
 	}
 	if err := renderGenericTable(tableCtx(&buf), item); err != nil {
 		t.Fatalf("render: %v", err)
 	}
 	got := buf.String()
 	if strings.Contains(got, "No results.") {
-		t.Fatalf("single MCP server item with empty tools was rendered as an empty list:\n%s", got)
+		t.Fatalf("single MCP server item was rendered as an empty list:\n%s", got)
 	}
 	for _, want := range []string{"FIELD", "VALUE", "SERVER_ID", "mcp_test", "SERVER_NAME", "github"} {
 		if !strings.Contains(got, want) {

internal/cli/oncall.go

@@ -245,11 +245,7 @@ func newOncallScheduleGetCmd() *cobra.Command {
 							return output.FormatTime(v.(flashduty.ScheduleCalculatedSchedule).End)
 						}},
 						{Header: "GROUP", MaxWidth: 30, Field: func(v any) string {
-							g := v.(flashduty.ScheduleCalculatedSchedule).Group
-							if g.GroupName != "" {
-								return g.GroupName
-							}
-							return g.Name
+							return scheduleGroupName(v.(flashduty.ScheduleCalculatedSchedule).Group)
 						}},
 					}
 
@@ -301,6 +297,18 @@ func scheduleLayerCount(s flashduty.ScheduleItem) string {
 	}
 }
 
+// scheduleGroupName resolves a schedule group's display name: the nullable
+// group_name when set, else the legacy name, else a placeholder.
+func scheduleGroupName(g flashduty.ScheduleGroup) string {
+	if g.GroupName != nil && *g.GroupName != "" {
+		return *g.GroupName
+	}
+	if g.Name != "" {
+		return g.Name
+	}
+	return "-"
+}
+
 // formatOncallMembers renders an on-call group's members as display names,
 // resolving person IDs through nameByID (best-effort, falling back to the
 // numeric ID), and finally to the group name when no members are present.
@@ -319,14 +327,7 @@ func formatOncallMembers(oncall *flashduty.ScheduleOncallGroup, nameByID map[int
 		}
 	}
 	if len(names) == 0 {
-		name := oncall.Group.GroupName
-		if name == "" {
-			name = oncall.Group.Name
-		}
-		if name != "" {
-			return name
-		}
-		return "-"
+		return scheduleGroupName(oncall.Group)
 	}
 	return strings.Join(names, ", ")
 }

internal/cli/root.go

@@ -151,6 +151,11 @@ func init() {
 	// operation stays reachable at safari session-export.
 	attachSafariSessionExport(rootCmd)
 	attachSafariAutomationTriggerFire(rootCmd)
+
+	// Multipart uploads are excluded from generation (non-JSON request body);
+	// attach their curated leaves to the generated path groups.
+	attachEnrichmentMappingDataUpload(rootCmd)
+	attachSafariSkillUpload(rootCmd)
 }
 
 // Execute runs the root command.