test: update package floor reason messages in tests

- Replace "Security fix" with "Filesystem upgrade" in package floor tests
- Use more realistic reason messages to avoid misleading
- Update backend/api/spec.yaml

Co-authored-by: Kai Lüke <[email protected]>
Signed-off-by: Ervin Rácz <[email protected]>

Author: ervcz

backend/api/spec.yaml

@@ -786,9 +786,9 @@ paths:
                 floor_reason:
                   type: string
                   nullable: true
-                  description: Optional reason for marking this package as a floor (e.g., "Security fix", "Critical update")
+                  description: Optional reason for marking this package as a floor (e.g., "Introduces needed filesystem support to handle new updates after this version")
                   maxLength: 500
-                  example: "Security fix for CVE-2024-1234"
+                  example: "Introduces btrfs support in update-engine to handle new updates after this version"
       responses:
         "200":
           description: Floor package relationship created or updated successfully
@@ -1665,7 +1665,7 @@ components:
           nullable: true
           description: Optional reason for marking this package as a floor
           maxLength: 500
-          example: "Security fix for CVE-2024-1234"
+          example: "Introduces needed filesystem support to handle new updates after this version"
         created_ts:
           type: string
           format: date-time

backend/pkg/api/packages_floors_test.go

@@ -19,7 +19,7 @@ func TestFloorOperations(t *testing.T) {
 
 	// Update floor reason for first floor
 	assert.NoError(t, a.RemoveChannelPackageFloor(setup.Channel.ID, setup.Floors[0].ID))
-	assert.NoError(t, a.AddChannelPackageFloor(setup.Channel.ID, setup.Floors[0].ID, null.StringFrom("Security fix")))
+	assert.NoError(t, a.AddChannelPackageFloor(setup.Channel.ID, setup.Floors[0].ID, null.StringFrom("Filesystem upgrade")))
 
 	// Test wrong arch
 	tTeam, err := a.AddTeam(&Team{Name: "test_team_arch"})
@@ -41,7 +41,7 @@ func TestFloorOperations(t *testing.T) {
 	assert.NoError(t, err)
 	assert.Len(t, floors, 2)
 	assert.Equal(t, "1000.0.0", floors[0].Version)
-	assert.Equal(t, "Security fix", floors[0].FloorReason.String)
+	assert.Equal(t, "Filesystem upgrade", floors[0].FloorReason.String)
 	assert.True(t, floors[0].IsFloor)
 
 	// Test required floors between versions
@@ -163,7 +163,7 @@ func TestFloorReason(t *testing.T) {
 	assert.Equal(t, reason, floors[0].FloorReason.String)
 
 	// Update reason (UPSERT)
-	newReason := "Updated: Security fix"
+	newReason := "Updated: Filesystem upgrade"
 	err = a.AddChannelPackageFloor(channel.ID, pkg.ID, null.StringFrom(newReason))
 	assert.NoError(t, err)
 
@@ -208,15 +208,15 @@ func TestTargetAsFloor(t *testing.T) {
 
 	// Mark the target as ALSO being a floor (critical version)
 	err := a.AddChannelPackageFloor(setup.Channel.ID, setup.Target.ID,
-		null.StringFrom("Critical security update - mandatory"))
+		null.StringFrom("Filesystem support for usr dir - mandatory"))
 	assert.NoError(t, err)
 
 	// Verify target is marked as floor
 	floors, err := a.GetChannelFloorPackages(setup.Channel.ID)
 	assert.NoError(t, err)
 	assert.Len(t, floors, 3) // All three are floors now
 	assert.Equal(t, "3000.0.0", floors[2].Version)
-	assert.Equal(t, "Critical security update - mandatory", floors[2].FloorReason.String)
+	assert.Equal(t, "Filesystem support for usr dir - mandatory", floors[2].FloorReason.String)
 
 	// Test required floors for different client versions
 	testCases := map[string]struct {

backend/pkg/codegen/spec.gen.go

@@ -14,7 +14,7 @@ import (
 func createMultiManifestUpdateWithReasons() *omaha.UpdateResponse {
 	update := createMultiManifestUpdate("1000.0.0", "2000.0.0", "3000.0.0")
 	// Set specific floor reasons for testing
-	update.Manifests[0].FloorReason = "Security fix"
+	update.Manifests[0].FloorReason = "Filesystem support for usr dir"
 	update.Manifests[1].FloorReason = "Critical update"
 	return update
 }
@@ -54,7 +54,7 @@ func TestSyncer_MultiManifestWithExistingPackage(t *testing.T) {
 	require.NoError(t, err)
 	assert.Len(t, floors, 2)
 	assert.Equal(t, "1000.0.0", floors[0].Version)
-	assert.Equal(t, "Security fix", floors[0].FloorReason.String)
+	assert.Equal(t, "Filesystem support for usr dir", floors[0].FloorReason.String)
 }
 
 // TestSyncer_PackageVerificationErrors tests hash/size mismatch detection
@@ -154,7 +154,7 @@ func TestSyncer_TargetAsFloor(t *testing.T) {
 				Packages:    []*omaha.Package{{Name: "flatcar-1000.0.0.gz", SHA1: "hash1000", Size: 1000}},
 				Actions:     []*omaha.Action{{Event: "postinstall", SHA256: "dGVzdHNoYTI1Ng=="}},
 				IsFloor:     true,
-				FloorReason: "Security update",
+				FloorReason: "Critical bootloader update",
 			},
 			{
 				Version:     "2000.0.0",
@@ -177,7 +177,7 @@ func TestSyncer_TargetAsFloor(t *testing.T) {
 	require.NoError(t, err)
 	assert.Len(t, floors, 2)
 	assert.Equal(t, "1000.0.0", floors[0].Version)
-	assert.Equal(t, "Security update", floors[0].FloorReason.String)
+	assert.Equal(t, "Critical bootloader update", floors[0].FloorReason.String)
 	assert.Equal(t, "2000.0.0", floors[1].Version)
 	assert.Equal(t, "Critical mandatory version", floors[1].FloorReason.String)
 
@@ -313,7 +313,7 @@ func TestSyncer_ExplicitTargetPriority(t *testing.T) {
 				Packages:    []*omaha.Package{{Name: "flatcar-1000.0.0.gz", SHA1: "hash1000", Size: 1000}},
 				Actions:     []*omaha.Action{{Event: "postinstall", SHA256: "dGVzdHNoYTI1Ng=="}},
 				IsFloor:     true,
-				FloorReason: "Security fix",
+				FloorReason: "Filesystem support for usr dir",
 			},
 			{
 				Version:  "2000.0.0",