Skip to content

Commit 5410eb6

Browse files
committed
Drop Windows-specific script:\"\" hack from SeriousPython.run
serious_python.dart was passing `script: Platform.isWindows ? \"\" : null` to runProgram() — a workaround for the old C++ Windows plugin's HandleMethodCall which treated an empty script string as a sentinel for \"use appPath\". With the new unified `serious_python_run`, mode=SCRIPT with an empty source string runs nothing — so on Windows the embedded Python interpreter started, did nothing, and the bridge_example's retry loop timed out with 'Python did not register a handler within 30s'. Pass `script: null` on all platforms; let the platform impls' `script == null ? appPath : null` branch route to PATH mode uniformly. Also gate the macOS / iOS / Android jobs in test-bridge-build.yml with `if: false` for faster Windows iteration. Re-enable when Windows is green.
1 parent 07dea03 commit 5410eb6

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

‎.github/workflows/test-bridge-build.yml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ env:
1919
jobs:
2020
test_bridge_example_macos:
2121
name: Bridge example macOS round-trip (Python ${{ matrix.python_version }})
22+
# Temporarily gated off while iterating on Windows. Re-enable by removing
23+
# this `if: false`.
24+
if: false
2225
runs-on: macos-latest
2326
strategy:
2427
fail-fast: false
@@ -44,6 +47,7 @@ jobs:
4447
4548
test_bridge_example_ios:
4649
name: Bridge example iOS round-trip (Python ${{ matrix.python_version }})
50+
if: false # Temporarily gated off while iterating on Windows.
4751
runs-on: macos-latest
4852
timeout-minutes: 25
4953
strategy:
@@ -99,6 +103,7 @@ jobs:
99103
100104
test_bridge_example_android:
101105
name: Bridge example Android round-trip (Python ${{ matrix.python_version }})
106+
if: false # Temporarily gated off while iterating on Windows.
102107
runs-on: ubuntu-latest
103108
strategy:
104109
fail-fast: false

‎src/serious_python/lib/serious_python.dart‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ class SeriousPython {
6464
return runProgram(appPath,
6565
modulePaths: modulePaths,
6666
environmentVariables: environmentVariables,
67-
script: Platform.isWindows ? "" : null,
6867
sync: sync);
6968
}
7069

0 commit comments

Comments
 (0)