Repository navigation
Commit 5410eb6
committed
Drop Windows-specific script:\"\" hack from SeriousPython.run
serious_python.dart was passing `script: Platform.isWindows ? \"\" : null`
to runProgram() — a workaround for the old C++ Windows plugin's
HandleMethodCall which treated an empty script string as a sentinel for
\"use appPath\". With the new unified `serious_python_run`, mode=SCRIPT
with an empty source string runs nothing — so on Windows the embedded
Python interpreter started, did nothing, and the bridge_example's retry
loop timed out with 'Python did not register a handler within 30s'.
Pass `script: null` on all platforms; let the platform impls' `script
== null ? appPath : null` branch route to PATH mode uniformly.
Also gate the macOS / iOS / Android jobs in test-bridge-build.yml with
`if: false` for faster Windows iteration. Re-enable when Windows is
green.1 parent 07dea03 commit 5410eb6
2 files changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
22 | 25 | | |
23 | 26 | | |
24 | 27 | | |
| |||
44 | 47 | | |
45 | 48 | | |
46 | 49 | | |
| 50 | + | |
47 | 51 | | |
48 | 52 | | |
49 | 53 | | |
| |||
99 | 103 | | |
100 | 104 | | |
101 | 105 | | |
| 106 | + | |
102 | 107 | | |
103 | 108 | | |
104 | 109 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
68 | 67 | | |
69 | 68 | | |
70 | 69 | | |
| |||
0 commit comments