test: added test cases

Author: mihir-kandoi

erpnext/controllers/subcontracting_controller.py

@@ -589,9 +589,8 @@ def __get_materials_from_bom(self, item_code, bom_no, exploded_item=0):
 		to_remove = []
 		for item in data:
 			if item.is_phantom_item:
-				data = (
-					self.__get_materials_from_bom(item.rm_item_code, item.bom_no, exploded_item=exploded_item)
-					+ data
+				data += self.__get_materials_from_bom(
+					item.rm_item_code, item.bom_no, exploded_item=exploded_item
 				)
 				to_remove.append(item)
 

erpnext/controllers/tests/test_subcontracting_controller.py

@@ -1141,6 +1141,28 @@ def test_return_non_consumed_materials_with_serial_batch_fields(self):
 			itemwise_details.get(doc.items[0].item_code)["serial_no"][5:6],
 		)
 
+	def test_phantom_bom_explosion(self):
+		from erpnext.manufacturing.doctype.bom.test_bom import create_tree_for_phantom_bom_tests
+
+		expected = create_tree_for_phantom_bom_tests()
+		service_items = [
+			{
+				"warehouse": "_Test Warehouse - _TC",
+				"item_code": "Subcontracted Service Item 11",
+				"qty": 5,
+				"rate": 100,
+				"fg_item": "Top Level Parent",
+				"fg_item_qty": 5,
+			},
+		]
+		sco = get_subcontracting_order(service_items=service_items, do_not_submit=True)
+		sco.items[0].include_exploded_items = 0
+		sco.save()
+		sco.submit()
+		sco.reload()
+
+		self.assertEqual([item.rm_item_code for item in sco.supplied_items], expected)
+
 
 def add_second_row_in_scr(scr):
 	item_dict = {}
@@ -1309,6 +1331,7 @@ def make_subcontracted_items():
 		"Subcontracted Item SA8": {},
 		"Subcontracted Item SA9": {"stock_uom": "Litre"},
 		"Subcontracted Item SA10": {},
+		"Top Level Parent": {},
 	}
 
 	for item, properties in sub_contracted_items.items():
@@ -1360,6 +1383,7 @@ def make_service_items():
 		"Subcontracted Service Item 8": {},
 		"Subcontracted Service Item 9": {},
 		"Subcontracted Service Item 10": {},
+		"Subcontracted Service Item 11": {},
 	}
 
 	for item, properties in service_items.items():
@@ -1385,6 +1409,7 @@ def make_bom_for_subcontracted_items():
 		"Subcontracted Item SA7": ["Subcontracted SRM Item 1"],
 		"Subcontracted Item SA8": ["Subcontracted SRM Item 8"],
 		"Subcontracted Item SA10": ["Subcontracted SRM Item 10"],
+		"Subcontracted Service Item 11": ["Top Level Parent"],
 	}
 
 	for item_code, raw_materials in boms.items():

erpnext/manufacturing/doctype/bom/test_bom.py

@@ -794,7 +794,7 @@ def level_order_traversal(node):
 	return traversal
 
 
-def create_nested_bom(tree, prefix="_Test bom ", submit=True):
+def create_nested_bom(tree, prefix="_Test bom ", phantom_items=None, submit=True):
 	"""Helper function to create a simple nested bom from tree describing item names. (along with required items)"""
 
 	def create_items(bom_tree):
@@ -806,6 +806,9 @@ def create_items(bom_tree):
 				).insert()
 			create_items(subtree)
 
+	if not phantom_items:
+		phantom_items = []
+
 	create_items(tree)
 
 	def dfs(tree, node):
@@ -824,7 +827,7 @@ def dfs(tree, node):
 		child_items = dfs(tree, item)
 		if child_items:
 			bom_item_code = prefix + item
-			bom = frappe.get_doc(doctype="BOM", item=bom_item_code)
+			bom = frappe.get_doc(doctype="BOM", item=bom_item_code, is_phantom_bom=item in phantom_items)
 			for child_item in child_items.keys():
 				bom.append("items", {"item_code": prefix + child_item})
 			bom.company = "_Test Company"
@@ -906,3 +909,15 @@ def create_process_loss_bom_item(item_tuple):
 		return make_item(item_code, {"stock_uom": stock_uom, "valuation_rate": 100})
 	else:
 		return frappe.get_doc("Item", item_code)
+
+
+def create_tree_for_phantom_bom_tests():  # returns expected explosion result
+	bom_tree_1 = {
+		"Top Level Parent": {
+			"Sub Assembly Level 1-1": {"Phantom Item Level 1-2": {"Item Level 1-3": {}}},
+			"Phantom Item Level 2-1": {"Phantom Item Level 2-2": {"Item Level 2-3": {}}},
+		}
+	}
+	phantom_list = ["Phantom Item Level 1-2", "Phantom Item Level 2-1", "Phantom Item Level 2-2"]
+	create_nested_bom(bom_tree_1, prefix="", phantom_items=phantom_list)
+	return ["Sub Assembly Level 1-1", "Item Level 2-3"]

erpnext/manufacturing/doctype/production_plan/test_production_plan.py

@@ -2362,11 +2362,7 @@ def test_stock_reservation_of_batch_nos_against_production_plan(self):
 		frappe.db.set_single_value("Stock Settings", "enable_stock_reservation", 0)
 
 	def test_production_plan_for_partial_sub_assembly_items(self):
-		from erpnext.controllers.status_updater import OverAllowanceError
 		from erpnext.manufacturing.doctype.bom.test_bom import create_nested_bom
-		from erpnext.subcontracting.doctype.subcontracting_bom.test_subcontracting_bom import (
-			create_subcontracting_bom,
-		)
 
 		frappe.flags.test_print = False
 
@@ -2418,6 +2414,30 @@ def test_production_plan_for_partial_sub_assembly_items(self):
 		for row in plan.sub_assembly_items:
 			self.assertEqual(row.ordered_qty, 10.0)
 
+	def test_phantom_bom_explosion(self):
+		from erpnext.manufacturing.doctype.bom.test_bom import create_tree_for_phantom_bom_tests
+
+		create_tree_for_phantom_bom_tests()
+
+		plan = create_production_plan(
+			item_code="Top Level Parent",
+			planned_qty=10,
+			use_multi_level_bom=1,
+			do_not_submit=True,
+			company="_Test Company",
+			skip_getting_mr_items=True,
+		)
+		plan.get_sub_assembly_items()
+		plan.submit()
+
+		plan.set("mr_items", [])
+		mr_items = get_items_for_material_requests(plan.as_dict())
+		for d in mr_items:
+			plan.append("mr_items", d)
+
+		self.assertEqual(plan.sub_assembly_items[0].production_item, "Sub Assembly Level 1-1")
+		self.assertEqual([item.item_code for item in plan.mr_items], ["Item Level 2-3", "Item Level 1-3"])
+
 
 def create_production_plan(**args):
 	"""

erpnext/manufacturing/doctype/work_order/test_work_order.py

@@ -3270,6 +3270,14 @@ def test_reserved_serial_batch(self):
 		)
 		frappe.db.set_single_value("Stock Settings", "auto_reserve_serial_and_batch", original_auto_reserve)
 
+	def test_phantom_bom_explosion(self):
+		from erpnext.manufacturing.doctype.bom.test_bom import create_tree_for_phantom_bom_tests
+
+		expected = create_tree_for_phantom_bom_tests()
+
+		wo = make_wo_order_test_record(item="Top Level Parent")
+		self.assertEqual([item.item_code for item in wo.required_items], expected)
+
 
 def get_reserved_entries(voucher_no, warehouse=None):
 	doctype = frappe.qb.DocType("Stock Reservation Entry")