fix: change fieldtype from link to data for document_type in producti… #50443
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vigneshsekar
requested review from
mihir-kandoi and
rohitwaghchaure
as code owners
Contributor
📝 WalkthroughWalkthroughThe Document Type column in the production_plan_summary report was changed from a Link field type (referencing the DocType document type) to a plain Data field type. This modification removes the hyperlink behavior and associated DocType-specific options from the column, converting it to display as plain text in the report output. Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mihir-kandoi
added a commit
that referenced
this pull request
Nov 11, 2025
…… (backport #50443) (#50455) Co-authored-by: Pugazhendhi Velu <[email protected]>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 11, 2025
# [15.88.0](v15.87.2...v15.88.0) (2025-11-11) ### Bug Fixes * add company filter for default warehouse for sales return ([32d3fbf](32d3fbf)) * add is_group filter in task for timesheet ([0f00581](0f00581)) * add missing stock entry UOM filtering based on item master ([#50135](#50135)) ([8f2002d](8f2002d)) * add validation to reject empty readings ([ac0375f](ac0375f)) * apply company,is_group filter for cost center ([b181686](b181686)) * automatically append taxes if taxes_and_charges is set in Buying controller ([25f5fb7](25f5fb7)) * **buying:** fetch Cost Center from Project ([e8e26a9](e8e26a9)) * change fieldtype from link to data for document_type in producti… (backport [#50443](#50443)) ([#50455](#50455)) ([a3ddc95](a3ddc95)) * change fieldtype from link to data for document_type in production plan summary ([9012a72](9012a72)) * check warehouse account before accessing ([79b3af6](79b3af6)) * ensure that additional discount amount is not mapped repeatedly ([44539f0](44539f0)) * handle partial dn against reserved stock ([9d979e3](9d979e3)) * handle returns as well ([9ed40cc](9ed40cc)) * hide total row in general ledger report ([56bb88d](56bb88d)) * ignore Department doctype ([32182d7](32182d7)) * include cost_center and project upon accounting dimension fetch ([3f490f1](3f490f1)) * material request item quantity validation against sales order with over-receipt allowance ([f2fef54](f2fef54)) * **material request:** set default buying price list if not exists ([670c6dc](670c6dc)) * Nonetype error if reserved stock is not present ([b8ec3ae](b8ec3ae)) * Pass stock_qty and picked_qty in transfer entry ([95ea9ca](95ea9ca)) * removed the validation ([080e9a3](080e9a3)) * reset billing and shipping address when company changes ([73b8a29](73b8a29)) * resolve conflict ([7d593dd](7d593dd)) * set company before creating asset movement to avoid permission error ([3fad90e](3fad90e)) * show only stock items in delivered items to be billed and received items to be billed reports ([3dbc90a](3dbc90a)) * state_to_state_province for translation ([#50244](#50244)) ([d4f6ca3](d4f6ca3)) * **stock:** ignore current voucher in reserved stock validation ([0e7f971](0e7f971)) * **Timesheet:** don't use billing_hours for costing amount ([#50394](#50394)) ([29c976e](29c976e)) * trends report total mismatch with group filters ([7e3f30b](7e3f30b)) * Update pick list locations quantity ([ce7ab8d](ce7ab8d)) * update uom when item changes ([2a2ae9a](2a2ae9a)) * validate is_group for parent task ([3380dea](3380dea)) * validate that discount amount cannot exceed total before discount ([e559faf](e559faf)) ### Features * **account settings:** add checkbox to show balances in payment entry ([90500f0](90500f0)) * add asset name column ([c486471](c486471)) * make material transfer warehouse validation optional (backport [#50461](#50461)) ([#50462](#50462)) ([1747e83](1747e83)) * process period closing voucher ([c8e3da0](c8e3da0)) ### Performance Improvements * serial no creation ([6ba2491](6ba2491))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue :
When a normal user tries to access Production Plan Summary report, a permission error occurs because the Document Type column is defined as a Link field pointing to the DocType doctype.
Since only users with the System Manager role or Administrator user have read access to the DocType doctype, other users are unable to load the report.
Ref : #51054
Backport needed: v15