fix: desktop icons

[rohitwaghchaure]

Fixed #50618

[coderabbitai]

📝 Walkthrough

Walkthrough

Four desktop icon configuration files under erpnext/desktop_icon were updated to add or change the icon property and update their modified timestamps: Banking → dollar-sign, Opening & Closing → panel-top-open, Subscription → monitor-check (was accounting), and Taxes → book-text. Additionally, a new workspace sidebar document was added at erpnext/workspace_sidebar/settings.json containing a "Settings" Workspace Sidebar with 12 configured sidebar items (Home, CRM Settings, Selling Settings, Buying Settings, Accounts Settings, Stock Settings, Manufacturing Settings, Print Settings, System Settings, Global Defaults, Projects Settings) and associated metadata.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Changes include multiple small, similar edits to JSON desktop icon files and a new, larger declarative workspace_sidebar JSON — mixed complexity.
• Review focus:
  • Validate JSON structure and formatting for all modified and new files.
  • Confirm the new icon values match available icon set names.
  • Inspect workspace_sidebar/settings.json for correct item links, link_type, parent/parentfield consistency, and ordering/indexes.

Possibly related PRs

• refactor: Workspace sidebars and desktop icons for erpnext modules #50492 — Edits icon fields and timestamps in the same erpnext/desktop_icon JSON files and adds the workspace_sidebar/settings.json file (strong file/content overlap).

Suggested labels

skip-release-notes

Suggested reviewers

• ruthra-kumar

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix: desktop icons' is directly related to the changeset, which updates and adds desktop icons across multiple JSON configuration files.
Description check	✅ Passed	The description references issue #50618, which is the issue being fixed by this changeset of desktop icon updates.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 44d95ec and 124293b.

📒 Files selected for processing (5)

• erpnext/desktop_icon/banking.json (1 hunks)
• erpnext/desktop_icon/opening_&_closing.json (1 hunks)
• erpnext/desktop_icon/subscription.json (1 hunks)
• erpnext/desktop_icon/taxes.json (1 hunks)
• erpnext/workspace_sidebar/settings.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• erpnext/desktop_icon/taxes.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Summary

🔇 Additional comments (5)

erpnext/desktop_icon/opening_&_closing.json (1)

7-7: Confirm icon name validity and semantic appropriateness.

The panel-top-open icon is applied to the "Opening & Closing" desktop icon. Verify this identifier is supported and semantically accurate for this module.

erpnext/desktop_icon/subscription.json (1)

7-7: Verify icon change rationale and validity.

The icon has changed from accounting to monitor-check. Confirm this icon identifier is valid and that the semantic shift from accounting-related to monitoring-related iconography is intentional for the Subscription module.

erpnext/workspace_sidebar/settings.json (2)

8-262: All workspace sidebar items reference valid, accessible DocTypes and workspaces. The 10 settings targets include 8 ERPNext-specific DocTypes and 2 Frappe framework Single documents (Print Settings, System Settings), all confirmed present in the codebase and properly integrated via setup/install.py. The "Settings" workspace exists and is properly deployed. Navigation links are intact.

---

1-262: All icon names and workspace/doctype references are valid.

Verification confirms:

• All 10 referenced DocTypes exist (CRM Settings, Selling Settings, Buying Settings, Accounts Settings, Stock Settings, Manufacturing Settings, Projects Settings, Global Defaults in ERPNext; Print Settings and System Settings in Frappe core)
• All icon names (home, crm, sell, buying, accounting, stock, building-2, printer, computer, earth, projects) are valid Frappe SVG icon identifiers
• File structure is correct with proper JSON formatting and metadata
• The Settings workspace sidebar integrates properly with existing ERPNext and Frappe components

erpnext/desktop_icon/banking.json (1)

7-7: No action required — icon names are valid.

The dollar-sign icon is already used across multiple configuration files in the codebase (workspace_sidebar/banking.json, receivables.json, payables.json, accounting.json, and the banking.json desktop icon under review). Similarly, panel-top-open is used in the opening_&_closing.json desktop icon file. This widespread use across similar configuration files confirms both icons are valid and supported in this ERPNext instance.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}