Skip to content

Commit 4170b55

Browse files
authored
Minor cleanup, use ::error:: before throwing exit code 1 (#67)
* Minor cleanup, use ::error:: before throwing exit code 1 * README: update checkout action version to v6
1 parent 1d5bdab commit 4170b55

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ jobs:
8080
runs-on: ubuntu-latest
8181

8282
steps:
83-
- uses: actions/checkout@v5
83+
- uses: actions/checkout@v6
8484
- uses: gap-actions/setup-gap@v3
8585
# ... additional steps using GAP will usually follow here
8686
```
@@ -111,7 +111,7 @@ jobs:
111111
steps:
112112
- uses: gap-actions/setup-cygwin@v2
113113
if: ${{ matrix.os == 'windows-latest' }}
114-
- uses: actions/checkout@v5
114+
- uses: actions/checkout@v6
115115
- uses: gap-actions/setup-gap@v3
116116
with:
117117
gap-version: ${{ matrix.gap-version }}

action.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ inputs:
3737
description: 'make bootstrap-pkg-? (i.e. full/minimal)'
3838
required: false
3939
default: 'REMOVED'
40-
40+
4141
runs:
4242
using: "composite"
4343
steps:
@@ -74,7 +74,7 @@ runs:
7474
echo "::error::Please see 'https://github.com/gap-actions/setup-gap/blob/main/README.md' for further information."
7575
exit 1
7676
fi
77-
77+
7878
- name: "Install dependencies"
7979
shell: bash
8080
if: ${{ runner.os != 'Windows' }}
@@ -132,7 +132,7 @@ runs:
132132
echo "Version: exact tag match"
133133
VERSION=${{ inputs.gap-version }}
134134
else
135-
echo "No release, branch or tag with name ${{ inputs.gap-version }} found"
135+
echo "::error::No release, branch or tag with name ${{ inputs.gap-version }} found"
136136
exit 1
137137
fi
138138
fi
@@ -165,7 +165,7 @@ runs:
165165
CHK=${CHK#\\}
166166
# Compare checksums
167167
if [[ "$SHA" != "$CHK" ]] ; then
168-
echo "Checksum is wrong!"
168+
echo "::error::Checksum is wrong!"
169169
exit 1
170170
fi
171171
# Extract archive
@@ -180,7 +180,7 @@ runs:
180180
run: |
181181
cd $GAPROOT
182182
CONFIGFLAGS="${{ inputs.configflags }}"
183-
183+
184184
if [ -f "autogen.sh" ] ; then
185185
echo "::group:: Running autogen"
186186
./autogen.sh
@@ -194,7 +194,7 @@ runs:
194194
./configure $CONFIGFLAGS
195195
196196
echo "::group:: Running make"
197-
make -j4 V=1
197+
make -j$(nproc) V=1
198198
199199
- name: "Make GAP executable"
200200
shell: bash

0 commit comments

Comments
 (0)