fix: build error introduced by crashpad C++17 support (#1118)

* fix: build error introduced by `crashpad` C++17 support

* introduce a GCC 9.4.0 runner

* update dependencies for new runner

* remove new runner from old deps

* update crashpad

* update crashpad

* remove -Wno-gnu-include-next from senntry compile options

* update crashpad

* remove handle_ex target

* update crashpad

* remove gnu-include-next warnings only for non GNU compilers

* disable pedantic on sentry_boot.h for sentry_info.c

* reset werror for GCC until we fix the crashpad compat

* fix typo

Co-authored-by: JoshuaMoelans <[email protected]>

* update crashpad

---------

Co-authored-by: JoshuaMoelans <[email protected]>

Author: supervacuus

.github/workflows/ci.yml

@@ -44,6 +44,11 @@ jobs:
             CC: gcc-7
             CXX: g++-7
             TEST_X86: 1
+          - name: Linux (GCC 9.4.0)
+            os: ubuntu-20.04
+            CC: gcc
+            CXX: g++
+            # ERROR_ON_WARNINGS: 1
           - name: Linux (GCC 12)
             os: ubuntu-22.04
             CC: gcc-12
@@ -135,11 +140,17 @@ jobs:
           cache: "pip"
 
       - name: Installing Linux Dependencies
-        if: ${{ runner.os == 'Linux' && !env['TEST_X86'] }}
+        if: ${{ runner.os == 'Linux' && matrix.os != 'ubuntu-20.04' && !env['TEST_X86'] }}
         run: |
           sudo apt update
           sudo apt install cmake clang-14 clang-tools llvm kcov g++-12 valgrind zlib1g-dev libcurl4-openssl-dev
 
+      - name: Installing Linux GCC 9.4.0 Dependencies
+        if: ${{ runner.os == 'Linux' && matrix.os == 'ubuntu-20.04' && !env['TEST_X86'] }}
+        run: |
+          sudo apt update
+          sudo apt install cmake clang-tools llvm kcov g++ valgrind zlib1g-dev libcurl4-openssl-dev
+
       - name: Installing Linux 32-bit Dependencies
         if: ${{ runner.os == 'Linux' && env['TEST_X86'] }}
         run: |

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## Unreleased
+
+**Fixes**:
+
+- Fix a build error on older compilers introduced by C++17 support in `0.7.18` for the `crashpad` backend. ([#1118](https://github.com/getsentry/sentry-native/pull/1118), [crashpad#117](https://github.com/getsentry/crashpad/pull/117), [mini_chromium#2](https://github.com/getsentry/mini_chromium/pull/2))
+
 ## 0.7.18
 
 **Features**:

CMakeLists.txt

@@ -346,7 +346,11 @@ else()
 	target_compile_options(sentry PRIVATE $<BUILD_INTERFACE:-Wall -Wextra -Wpedantic>)
 	# The crashpad and breakpad headers generate the following warnings that we
 	# ignore specifically
-	target_compile_options(sentry PRIVATE $<BUILD_INTERFACE:-Wno-variadic-macros -Wno-gnu-include-next -Wno-multichar>)
+	if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+		target_compile_options(sentry PRIVATE $<BUILD_INTERFACE:-Wno-variadic-macros -Wno-multichar>)
+	else()
+		target_compile_options(sentry PRIVATE $<BUILD_INTERFACE:-Wno-variadic-macros -Wno-gnu-include-next -Wno-multichar>)
+	endif()
 	# ignore all warnings for mpack
 	set_source_files_properties(
 		"${PROJECT_SOURCE_DIR}/vendor/mpack.c"