fix(billing): Fix credit card expiration date display (#103112)

Author: dashed

static/gsApp/components/creditCardEdit/panel.tsx

@@ -1,6 +1,5 @@
 import {Fragment, useCallback, useEffect, useState} from 'react';
 import type {Location} from 'history';
-import moment from 'moment-timezone';
 
 import {Button} from 'sentry/components/core/button';
 import {Flex} from 'sentry/components/core/layout';
@@ -189,7 +188,7 @@ function CreditCardPanel({
           />
         ) : subscription.paymentSource ? (
           <Fragment>
-            <Text>{`****${subscription.paymentSource.last4} ${moment(new Date(subscription.paymentSource.expYear, subscription.paymentSource.expMonth - 1)).format('MM/YY')}`}</Text>
+            <Text>{`****${subscription.paymentSource.last4} ${String(subscription.paymentSource.expMonth).padStart(2, '0')}/${String(subscription.paymentSource.expYear).slice(-2)}`}</Text>
             <Text>{`${countryName ? `${countryName} ` : ''} ${subscription.paymentSource.zipCode}`}</Text>
           </Fragment>
         ) : (

static/gsApp/views/subscriptionPage/billingInformation.spec.tsx

@@ -615,4 +615,40 @@ describe('Billing details form', () => {
       inModal.queryByRole('textbox', {name: 'Street Address 1'})
     ).not.toBeInTheDocument();
   });
+
+  it('displays credit card expiration date', async () => {
+    organization.features = ['subscriptions-v3'];
+
+    const subscriptionWithCard = SubscriptionFixture({
+      organization,
+      paymentSource: {
+        last4: '4242',
+        countryCode: 'US',
+        zipCode: '94242',
+        expMonth: 8,
+        expYear: 2030,
+      },
+    });
+
+    MockApiClient.addMockResponse({
+      url: `/subscriptions/${organization.slug}/`,
+      method: 'GET',
+      body: subscriptionWithCard,
+    });
+
+    render(
+      <BillingInformation
+        organization={organization}
+        subscription={subscriptionWithCard}
+        location={router.location}
+      />
+    );
+
+    await screen.findByText('Billing Information');
+
+    const cardPanel = await screen.findByTestId('credit-card-panel');
+
+    // Verify payment method displays with correct expiration date format (MM/YY)
+    expect(within(cardPanel).getByText(/\*\*\*\*4242 08\/30/)).toBeInTheDocument();
+  });
 });