Skip to content

Commit 30cc2d9

Browse files
committed
fix typing
1 parent 22ae3bf commit 30cc2d9

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/sentry/search/eap/spans/filter_aliases.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ def semver_filter_converter(params: SnubaParams, search_filter: SearchFilter) ->
109109
project_ids=params.project_ids,
110110
)
111111
if order_by_build_code:
112-
qs = qs.annotate_build_code_column()
112+
qs = qs.annotate_build_code_column() # type: ignore[attr-defined] # mypy doesn't know about ReleaseQuerySet
113113
qs = qs.values_list("version", flat=True).order_by(*order_by)[: constants.MAX_SEARCH_RELEASES]
114114
versions = list(qs)
115115
final_operator: Literal["IN", "NOT IN"] = "IN"
@@ -126,7 +126,7 @@ def semver_filter_converter(params: SnubaParams, search_filter: SearchFilter) ->
126126
organization_id, parse_semver(version, operator)
127127
)
128128
if order_by_build_code:
129-
qs_flipped = qs_flipped.annotate_build_code_column()
129+
qs_flipped = qs_flipped.annotate_build_code_column() # type: ignore[attr-defined] # mypy doesn't know about ReleaseQuerySet
130130
qs_flipped = qs_flipped.order_by(*map(_flip_field_sort, order_by)).values_list(
131131
"version", flat=True
132132
)[: constants.MAX_SEARCH_RELEASES]

tests/sentry/rules/filters/test_latest_adopted_release.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
from sentry.rules.filters.latest_adopted_release_filter import (
44
LatestAdoptedReleaseFilter,
5-
LatestReleaseOrders,
65
is_newer_release,
76
)
7+
from sentry.search.utils import LatestReleaseOrders
88
from sentry.testutils.cases import RuleTestCase, TestCase
99

1010

tests/sentry/search/events/test_filter.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ def test_projects(self) -> None:
334334
project_id=[project_2.id],
335335
)
336336

337-
def test_build_code_ordering_with_limit(self) -> None:
337+
def test_build_code_ordering(self) -> None:
338338
"""
339339
Test that build code ordering affects which releases are returned when
340340
MAX_SEARCH_RELEASES limit is hit and feature flag is enabled.

0 commit comments

Comments
 (0)