Skip to content

Commit 35d845e

Browse files
Abdullah KhanAbdullah Khan
authored andcommitted
feat(trace-tree-node): Minor cleanup
1 parent 2d36bd3 commit 35d845e

File tree

2 files changed

+3
-13
lines changed

2 files changed

+3
-13
lines changed

static/app/views/performance/newTraceDetails/traceModels/traceTreeNode/spanNode.tsx

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,18 +44,10 @@ export class SpanNode extends BaseNode<TraceTree.Span> {
4444
);
4545
}
4646

47-
get description(): string | undefined {
48-
return this.value.description;
49-
}
50-
5147
get endTimestamp(): number {
5248
return this.value.timestamp;
5349
}
5450

55-
get startTimestamp(): number {
56-
return this.value.start_timestamp;
57-
}
58-
5951
get drawerTabsTitle(): string {
6052
return this.op + (this.value.description ? ' - ' + this.value.description : '');
6153
}

static/app/views/performance/newTraceDetails/traceModels/traceTreeNode/transactionNode.tsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -307,13 +307,11 @@ export class TransactionNode extends BaseNode<TraceTree.Transaction> {
307307

308308
parent.children.push(transaction);
309309
transaction.parent = parent;
310-
311-
// Invalidating the node and its children to ensure the tree is rebuilt correctly,
312-
// after we have potentially done some re-parenting.
313-
this.invalidate();
314-
this.forEachChild(child => child.invalidate());
315310
}
316311

312+
// Invalidating the node and its children to ensure the tree is rebuilt correctly,
313+
// after we have potentially done some re-parenting.
314+
this.invalidate();
317315
this.children.sort(traceChronologicalSort);
318316
this.forEachChild(c => {
319317
c.invalidate();

0 commit comments

Comments
 (0)