ref(groupingInfo): Delete EventGroupingInfoResponseOld (#101223)

Author: shayna-ch

static/app/components/events/groupingInfo/groupingInfoSection.spec.tsx

@@ -30,13 +30,16 @@ describe('EventGroupingInfo', () => {
     groupingInfoRequest = MockApiClient.addMockResponse({
       url: `/projects/org-slug/project-slug/events/${event.id}/grouping-info/`,
       body: {
-        app: {
-          contributes: true,
-          description: 'variant description',
-          hash: '123',
-          hashMismatch: false,
-          key: 'key',
-          type: EventGroupVariantType.CHECKSUM,
+        grouping_config: 'default:XXXX',
+        variants: {
+          app: {
+            contributes: true,
+            description: 'variant description',
+            hash: '123',
+            hashMismatch: false,
+            key: 'key',
+            type: EventGroupVariantType.CHECKSUM,
+          },
         },
       },
     });

static/app/components/events/groupingInfo/useEventGroupingInfo.tsx

@@ -8,38 +8,11 @@ import type {Group} from 'sentry/types/group';
 import {useApiQuery} from 'sentry/utils/queryClient';
 import useOrganization from 'sentry/utils/useOrganization';
 
-type EventGroupingInfoResponseOld = Record<string, EventGroupVariant>;
 type EventGroupingInfoResponse = {
   grouping_config: string | null;
   variants: Record<string, EventGroupVariant>;
 };
 
-// temporary function to convert the old response structure to the new one
-function eventGroupingInfoResponseOldToNew(
-  old: EventGroupingInfoResponseOld | null
-): EventGroupingInfoResponse | null {
-  const grouping_config = old
-    ? (
-        Object.values(old).find(
-          variant => 'config' in variant && variant.config?.id
-        ) as any
-      )?.config?.id
-    : null;
-  return old
-    ? {
-        grouping_config,
-        variants: old,
-      }
-    : null;
-}
-
-// temporary function to check if the respinse is old type
-function isOld(
-  data: EventGroupingInfoResponseOld | EventGroupingInfoResponse | null
-): data is EventGroupingInfoResponseOld {
-  return data ? !('grouping_config' in data) : false;
-}
-
 function generatePerformanceGroupInfo({
   event,
   group,
@@ -94,21 +67,18 @@ export function useEventGroupingInfo({
 
   const hasPerformanceGrouping = event.occurrence && event.type === 'transaction';
 
-  const {data, isPending, isError, isSuccess} = useApiQuery<
-    EventGroupingInfoResponseOld | EventGroupingInfoResponse
-  >([`/projects/${organization.slug}/${projectSlug}/events/${event.id}/grouping-info/`], {
-    enabled: !hasPerformanceGrouping,
-    staleTime: Infinity,
-  });
+  const {data, isPending, isError, isSuccess} = useApiQuery<EventGroupingInfoResponse>(
+    [`/projects/${organization.slug}/${projectSlug}/events/${event.id}/grouping-info/`],
+    {
+      enabled: !hasPerformanceGrouping,
+      staleTime: Infinity,
+    }
+  );
 
-  const groupInfoRaw = hasPerformanceGrouping
+  const groupInfo = hasPerformanceGrouping
     ? generatePerformanceGroupInfo({group, event})
     : (data ?? null);
 
-  const groupInfo = isOld(groupInfoRaw)
-    ? eventGroupingInfoResponseOldToNew(groupInfoRaw)
-    : groupInfoRaw;
-
   return {
     groupInfo,
     isPending,