Skip to content

Commit 3f039d0

Browse files
committed
comments
1 parent f2f3ef7 commit 3f039d0

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

src/sentry/search/eap/columns.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,6 @@ class ResolvedAggregate(ResolvedFunction):
201201

202202
# The internal rpc alias for this column
203203
internal_name: Function.ValueType
204-
# Whether to enable extrapolation
205204
extrapolation_mode: ExtrapolationMode.ValueType
206205
is_aggregate: bool = field(default=True, init=False)
207206
# Only for aggregates, we only support functions with 1 argument right now
@@ -229,7 +228,6 @@ class ResolvedMetricAggregate(ResolvedAggregate):
229228
class ResolvedConditionalAggregate(ResolvedFunction):
230229
# The internal rpc alias for this column
231230
internal_name: Function.ValueType
232-
# Whether to enable extrapolation
233231
extrapolation_mode: ExtrapolationMode.ValueType
234232
# The condition to filter on
235233
filter: TraceItemFilter
@@ -279,7 +277,7 @@ class FunctionDefinition:
279277
infer_search_type_from_arguments: bool = True
280278
# The internal rpc type for this function, optional as it can mostly be inferred from search_type
281279
internal_type: AttributeKey.Type.ValueType | None = None
282-
# Whether to request extrapolation or not, should be true for all functions except for _sample functions for debugging
280+
# Extrapolation mode to be used
283281
extrapolation_mode_override: ExtrapolationMode.ValueType | None = None
284282
# Processor is the function run in the post process step to transform a row into the final result
285283
processor: Callable[[Any], Any] | None = None

src/sentry/search/eap/types.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ class SearchResolverConfig:
3131
fields_acl: FieldsACL = field(default_factory=lambda: FieldsACL())
3232
# If set to True, do not extrapolate any values regardless of individual aggregate settings
3333
disable_aggregate_extrapolation: bool = False
34-
# If set to True, do not extrapolate any values regardless of individual aggregate settings
3534
extrapolation_mode: ExtrapolationMode.ValueType | None = None
3635
# Whether to set the timestamp granularities to stable buckets
3736
stable_timestamp_quantization: bool = True

0 commit comments

Comments
 (0)