chore(aci): Remove uses if is_single_written flag

Author: kcons

src/sentry/api/serializers/models/rule.py

@@ -222,9 +222,7 @@ def get_attrs(self, item_list, user, **kwargs):
                 )
 
                 workflow_fire_results = (
-                    WorkflowFireHistory.objects.filter(
-                        workflow_id__in=workflow_rule_lookup.keys(), is_single_written=True
-                    )
+                    WorkflowFireHistory.objects.filter(workflow_id__in=workflow_rule_lookup.keys())
                     .values("workflow_id")
                     .annotate(date_added=Max("date_added"))
                 )

src/sentry/rules/history/backends/postgres.py

@@ -86,7 +86,7 @@ def data_fn(offset: int, limit: int) -> list[_Result]:
                             UNION ALL
                             SELECT group_id, date_added, event_id
                             FROM workflow_engine_workflowfirehistory
-                            WHERE workflow_id = %s AND is_single_written = true
+                            WHERE workflow_id = %s
                             AND date_added >= %s AND date_added < %s
                         )
                         SELECT
@@ -180,7 +180,6 @@ def fetch_rule_hourly_stats(
                             SELECT date_added
                             FROM workflow_engine_workflowfirehistory
                             WHERE workflow_id = %s
-                                AND is_single_written = true
                                 AND date_added >= %s
                                 AND date_added < %s
                         ) combined_data

src/sentry/workflow_engine/endpoints/organization_workflow_index.py

@@ -198,9 +198,7 @@ def get(self, request, organization):
                 # to be more efficient than a Max() aggregation, because it lets us look at ~1
                 # workflow fire history row per workflow.
                 latest_fire_subquery = Subquery(
-                    WorkflowFireHistory.objects.filter(
-                        workflow=OuterRef("pk"), is_single_written=True
-                    )
+                    WorkflowFireHistory.objects.filter(workflow=OuterRef("pk"))
                     .order_by("-date_added")
                     .values("date_added")[:1]
                 )

src/sentry/workflow_engine/endpoints/serializers/timeseries_value_serializer.py

@@ -35,7 +35,6 @@ def fetch_workflow_hourly_stats(
             workflow=workflow,
             date_added__gte=start,
             date_added__lt=end,
-            is_single_written=True,
         )
         .annotate(bucket=TruncHour("date_added"))
         .order_by("bucket")

src/sentry/workflow_engine/endpoints/serializers/workflow_group_history_serializer.py

@@ -114,7 +114,6 @@ def fetch_workflow_groups_paginated(
         workflow=workflow,
         date_added__gte=start,
         date_added__lt=end,
-        is_single_written=True,
     )
 
     # subquery that retrieves row with the largest date in a group

src/sentry/workflow_engine/endpoints/serializers/workflow_serializer.py

@@ -37,7 +37,6 @@ def get_attrs(
         last_triggered_map: dict[int, datetime] = dict(
             WorkflowFireHistory.objects.filter(
                 workflow__in=item_list,
-                is_single_written=True,
             )
             .values("workflow_id")
             .annotate(last_triggered=Max("date_added"))

src/sentry/workflow_engine/processors/workflow_fire_history.py

@@ -35,11 +35,6 @@ def create_workflow_fire_histories(
     Record that the workflows associated with these actions were fired for this
     event.
 
-    Only records canonical entries (is_single_written=True). During migration from
-    dual-write to single-write, entries with is_single_written=False were created
-    for tracking purposes but are not the canonical record and should not be created
-    going forward.
-
     If we're reporting a fire due to delayed processing, is_delayed should be True.
     """
     # Only write canonical fire history records
@@ -75,7 +70,6 @@ def create_workflow_fire_histories(
             workflow_id=workflow_id,
             group=event_data.group,
             event_id=event_id,
-            is_single_written=is_single_processing,
         )
         for workflow_id in workflow_ids
     ]

tests/sentry/rules/history/backends/test_postgres.py

@@ -217,28 +217,16 @@ def test_combined_rule_and_workflow_history(self) -> None:
                 )
             )
 
-        # Create some WorkflowFireHistory entries with is_single_written=True
+        # Create some WorkflowFireHistory entries
         for i in range(2):
             wfh = WorkflowFireHistory.objects.create(
                 workflow=workflow,
                 group=self.group,
                 date_added=before_now(days=i + 3),
                 event_id=f"workflow_event_{i}",
-                is_single_written=True,
             )
             wfh.update(date_added=before_now(days=i + 3))
 
-        # Create some WorkflowFireHistory entries with is_single_written=False (should be ignored)
-        for i in range(2):
-            wfh = WorkflowFireHistory.objects.create(
-                workflow=workflow,
-                group=self.group,
-                date_added=before_now(days=i + 5),
-                event_id=f"workflow_event_ignored_{i}",
-                is_single_written=False,
-            )
-            wfh.update(date_added=before_now(days=i + 5))
-
         RuleFireHistory.objects.bulk_create(rule_history)
 
         group_2 = self.create_group()
@@ -254,7 +242,6 @@ def test_combined_rule_and_workflow_history(self) -> None:
             group=group_2,
             date_added=before_now(days=2),
             event_id="workflow_event_group2",
-            is_single_written=True,
         )
         new_workflow_history.update(date_added=before_now(days=2))
 
@@ -382,7 +369,6 @@ def test_combined_rule_and_workflow_history(self) -> None:
             workflow=workflow,
             group=self.group,
             date_added=before_now(hours=1),
-            is_single_written=True,
         )
         wfh.update(date_added=before_now(hours=1))
         # Hour 3: 2 workflow fire entries
@@ -391,20 +377,9 @@ def test_combined_rule_and_workflow_history(self) -> None:
                 workflow=workflow,
                 group=self.group,
                 date_added=before_now(hours=3),
-                is_single_written=True,
             )
             wfh.update(date_added=before_now(hours=3))
 
-        # is_single_written=False WFH should be ignored
-        for _ in range(3):
-            wfh = WorkflowFireHistory.objects.create(
-                workflow=workflow,
-                group=self.group,
-                date_added=before_now(hours=1),
-                is_single_written=False,
-            )
-            wfh.update(date_added=before_now(hours=1))
-
         RuleFireHistory.objects.bulk_create(rule_history)
 
         results = self.backend.fetch_rule_hourly_stats(rule, before_now(hours=24), before_now())

tests/sentry/workflow_engine/endpoints/serializers/test_workflow_serializer.py

@@ -92,26 +92,15 @@ def test_serialize_full(self) -> None:
             workflow=workflow,
             group=self.group,
             event_id=self.event.event_id,
-            is_single_written=True,
         )
         # Too old, shouldn't be used.
         WorkflowFireHistory.objects.create(
             workflow=workflow,
             group=self.group,
             event_id=self.event.event_id,
-            is_single_written=True,
         )
         history.date_added = workflow.date_added + timedelta(seconds=1)
         history.save()
-        # Dual written, shouldn't be used.
-        dual_written_history = WorkflowFireHistory.objects.create(
-            workflow=workflow,
-            group=self.group,
-            event_id=self.event.event_id,
-            is_single_written=False,
-        )
-        dual_written_history.date_added = workflow.date_added + timedelta(seconds=2)
-        dual_written_history.save()
 
         result = serialize(workflow)
 

tests/sentry/workflow_engine/endpoints/test_organization_workflow_index.py

@@ -53,7 +53,6 @@ def setUp(self) -> None:
                 workflow=workflow,
                 group=self.group,
                 event_id=self.event.event_id,
-                is_single_written=True,
             )
 
     def test_simple(self) -> None:
@@ -211,13 +210,6 @@ def test_sort_by_actions(self) -> None:
         ][0]
 
     def test_sort_by_last_triggered(self) -> None:
-        # Fresh fire for self.workflow that would impact sorting if not ignored.
-        WorkflowFireHistory.objects.create(
-            workflow=self.workflow,
-            group=self.group,
-            event_id=self.event.event_id,
-            is_single_written=False,
-        )
         response = self.get_success_response(
             self.organization.slug, qs_params={"sortBy": "lastTriggered"}
         )
@@ -358,28 +350,27 @@ def test_sort_by_last_triggered_with_non_single_written_only(self) -> None:
             organization_id=self.organization.id, name="Never Fired"
         )
 
-        workflow_non_single_written_only = self.create_workflow(
-            organization_id=self.organization.id, name="Non Single Written Only"
+        workflow_with_history = self.create_workflow(
+            organization_id=self.organization.id, name="With History"
         )
         WorkflowFireHistory.objects.create(
-            workflow=workflow_non_single_written_only,
+            workflow=workflow_with_history,
             group=self.group,
             event_id=self.event.event_id,
-            is_single_written=False,
         )
 
         # Test ascending order (lastTriggered)
         response = self.get_success_response(
             self.organization.slug, qs_params={"sortBy": "lastTriggered"}
         )
 
-        # Workflows without single-written history should come first, then those with it
+        # Workflows without history should come first, then those with it
         expected_ascending_order = [
             self.workflow_three.name,
             workflow_never_fired.name,
-            workflow_non_single_written_only.name,
             self.workflow.name,
             self.workflow_two.name,
+            workflow_with_history.name,
         ]
 
         assert [w["name"] for w in response.data] == expected_ascending_order
@@ -389,11 +380,11 @@ def test_sort_by_last_triggered_with_non_single_written_only(self) -> None:
             self.organization.slug, qs_params={"sortBy": "-lastTriggered"}
         )
 
-        # In descending order, workflows with single-written history should come first
+        # In descending order, workflows with history should come first
         expected_descending_order = [
+            workflow_with_history.name,
             self.workflow_two.name,
             self.workflow.name,
-            workflow_non_single_written_only.name,
             workflow_never_fired.name,
             self.workflow_three.name,
         ]