Skip to content

Commit 9eb63c8

Browse files
committed
ref(ui): do not disable eslint-plugin-query for debouncing
1 parent 8019d6f commit 9eb63c8

File tree

2 files changed

+10
-15
lines changed

2 files changed

+10
-15
lines changed

static/app/components/searchQueryBuilder/tokens/filter/valueCombobox.tsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -365,18 +365,16 @@ function useFilterSuggestions({
365365
);
366366

367367
const baseQueryKey = useMemo(
368-
() => ['search-query-builder-tag-values', queryParams],
368+
() => ['search-query-builder-tag-values', queryParams] as const,
369369
[queryParams]
370370
);
371371
const queryKey = useDebouncedValue(baseQueryKey);
372372
const isDebouncing = baseQueryKey !== queryKey;
373373

374374
// TODO(malwilley): Display error states
375-
const {data, isFetching} = useQuery<string[]>({
376-
// disable exhaustive deps because we want to debounce the query key above
377-
// eslint-disable-next-line @tanstack/query/exhaustive-deps
375+
const {data, isFetching} = useQuery({
378376
queryKey,
379-
queryFn: () => getTagValues(...queryParams),
377+
queryFn: ctx => getTagValues(...ctx.queryKey[1]),
380378
placeholderData: keepPreviousData,
381379
enabled: shouldFetchValues,
382380
});

static/app/views/dashboards/globalFilter/filterSelector.tsx

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -83,16 +83,13 @@ function FilterSelector({
8383
? !fullTag.predefined && predefinedValues === null
8484
: true;
8585

86-
const baseQueryKey = useMemo(
87-
() => ['global-dashboard-filters-tag-values', tag, selection, searchQuery],
88-
[tag, selection, searchQuery]
89-
);
90-
const queryKey = useDebouncedValue(baseQueryKey);
91-
92-
const queryResult = useQuery<string[]>({
93-
// Disable exhaustive deps because we want to debounce the query key above
94-
// eslint-disable-next-line @tanstack/query/exhaustive-deps
95-
queryKey,
86+
const queryResult = useQuery({
87+
queryKey: useDebouncedValue(
88+
useMemo(
89+
() => ['global-dashboard-filters-tag-values', tag, selection, searchQuery],
90+
[tag, selection, searchQuery]
91+
)
92+
),
9693
queryFn: async () => {
9794
const result = await searchBarData.getTagValues(tag, searchQuery);
9895
return result ?? [];

0 commit comments

Comments
 (0)