Skip to content

Commit bf44c8c

Browse files
committed
grouping config type
1 parent ed5de2e commit bf44c8c

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

static/app/components/events/groupingInfo/groupingSummary.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export function GroupInfoSummary({
3030
.join(', ')
3131
: t('nothing');
3232

33-
const groupingConfig = showGroupingConfig && groupInfo?.grouping_config;
33+
const groupingConfig = showGroupingConfig && groupInfo?.grouping_config?.id;
3434

3535
if (isPending && !hasPerformanceGrouping) {
3636
return (

static/app/components/events/groupingInfo/useEventGroupingInfo.tsx

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import {t} from 'sentry/locale';
22
import {
33
EventGroupVariantType,
44
type Event,
5+
type EventGroupingConfig,
56
type EventGroupVariant,
67
} from 'sentry/types/event';
78
import type {Group} from 'sentry/types/group';
@@ -10,7 +11,7 @@ import useOrganization from 'sentry/utils/useOrganization';
1011

1112
type EventGroupingInfoResponseOld = Record<string, EventGroupVariant>;
1213
type EventGroupingInfoResponse = {
13-
grouping_config: string;
14+
grouping_config: EventGroupingConfig | null;
1415
variants: Record<string, EventGroupVariant>;
1516
};
1617

@@ -19,11 +20,8 @@ function eventGroupingInfoResponseOldToNew(
1920
old: EventGroupingInfoResponseOld | null
2021
): EventGroupingInfoResponse | null {
2122
const grouping_config = old
22-
? (
23-
Object.values(old).find(
24-
variant => 'config' in variant && variant.config?.id
25-
) as any
26-
)?.config?.id
23+
? (Object.values(old).find(variant => 'config' in variant && variant.config) as any)
24+
?.config
2725
: null;
2826
return old
2927
? {
@@ -57,7 +55,7 @@ function generatePerformanceGroupInfo({
5755

5856
return group
5957
? {
60-
grouping_config: 'performance',
58+
grouping_config: null,
6159
variants: {
6260
[group.issueType]: {
6361
contributes: true,

0 commit comments

Comments
 (0)