fix tests

Author: cathteng

tests/sentry/workflow_engine/endpoints/test_organization_test_fire_action.py

@@ -95,7 +95,10 @@ def test_pagerduty_action(
         assert response.status_code == 200
         assert mock_send_trigger.call_count == 1
         pagerduty_data = mock_send_trigger.call_args.kwargs.get("data")
-        assert pagerduty_data["payload"]["summary"].startswith(f"[{self.detector.name}]:")
+        # test notification has its own type, so it will pick up the issue stream detector
+        assert pagerduty_data["payload"]["summary"].startswith(
+            f"[{self.issue_stream_detector.name}]:"
+        )
 
     @mock.patch.object(NotifyEventAction, "after")
     @mock.patch(

tests/sentry/workflow_engine/models/test_action.py

@@ -70,7 +70,7 @@ def test_get_handler_unregistered_type(self) -> None:
             # Verify the registry was queried with the correct action type
             mock_get.assert_called_once_with(Action.Type.SLACK)
 
-    @patch("sentry.workflow_engine.processors.detector.get_detector_by_event")
+    @patch("sentry.workflow_engine.processors.detector.get_detector_by_group")
     def test_trigger_calls_handler_execute(self, mock_get_detector: MagicMock) -> None:
         mock_handler = Mock(spec=ActionHandler)
         mock_get_detector.return_value = Mock(spec=Detector, type="error")
@@ -82,7 +82,7 @@ def test_trigger_calls_handler_execute(self, mock_get_detector: MagicMock) -> No
                 self.mock_event, self.action, mock_get_detector.return_value
             )
 
-    @patch("sentry.workflow_engine.processors.detector.get_detector_by_event")
+    @patch("sentry.workflow_engine.processors.detector.get_detector_by_group")
     def test_trigger_with_failing_handler(self, mock_get_detector: MagicMock) -> None:
         mock_handler = Mock(spec=ActionHandler)
         mock_handler.execute.side_effect = Exception("Handler failed")
@@ -93,7 +93,7 @@ def test_trigger_with_failing_handler(self, mock_get_detector: MagicMock) -> Non
                 self.action.trigger(self.mock_event)
 
     @patch("sentry.utils.metrics.incr")
-    @patch("sentry.workflow_engine.processors.detector.get_detector_by_event")
+    @patch("sentry.workflow_engine.processors.detector.get_detector_by_group")
     def test_trigger_metrics(self, mock_get_detector: MagicMock, mock_incr: MagicMock) -> None:
         mock_handler = Mock(spec=ActionHandler)
         mock_get_detector.return_value = Mock(spec=Detector, type="error")