Skip to content

Commit f14233e

Browse files
committed
Fix another test
1 parent f25849f commit f14233e

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

tests/sentry/workflow_engine/migration_helpers/test_migrate_rule_action.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ def assert_action_data_blob(
114114
assert action.data.get(field) == source_value
115115
else:
116116
# For unmapped fields, check directly with empty string default
117-
if action.type == Action.Type.EMAIL and field == "fallthroughType":
118-
# for email actions, the default value for fallthroughType should be "ActiveMembers"
117+
if action.type == Action.Type.EMAIL and field == "fallthrough_type":
118+
# for email actions, the default value for fallthrough_type should be "ActiveMembers"
119119
assert action.data.get(field) == compare_dict.get(
120120
field, "ActiveMembers"
121121
)
@@ -131,10 +131,10 @@ def assert_action_data_blob(
131131
if key not in exclude_keys:
132132
if (
133133
action.type == Action.Type.EMAIL
134-
and key == "fallthroughType"
134+
and key == "fallthrough_type"
135135
and action.config.get("target_type") != ActionTarget.ISSUE_OWNERS
136136
):
137-
# for email actions, fallthroughType should only be set for when targetType is ISSUE_OWNERS
137+
# for email actions, fallthrough_type should only be set for when targetType is ISSUE_OWNERS
138138
continue
139139
else:
140140
assert compare_dict[key] == action.data[key]
@@ -626,9 +626,9 @@ def test_email_migration_malformed(self) -> None:
626626
{
627627
"uuid": "12345678-90ab-cdef-0123-456789abcdef",
628628
"id": "sentry.mail.actions.NotifyEmailAction",
629-
"fallthroughType": "NoOne",
629+
"fallthrough_type": "NoOne",
630630
},
631-
# This should be ok since we have a default value for fallthroughType
631+
# This should be ok since we have a default value for fallthrough_type
632632
{
633633
"uuid": "12345678-90ab-cdef-0123-456789abcdef",
634634
"id": "sentry.mail.actions.NotifyEmailAction",

0 commit comments

Comments
 (0)