-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
ref(explorer): rpc to support issue/event detail queries with event id only #103787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
roaga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
roaga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok let's remember to clean up the old one
src/sentry/seer/explorer/tools.py
Outdated
| Returns: | ||
| A dict containing: | ||
| Issue fields (nullable iff issue_id is None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confused on this distinction between nullable and non nullable fields. If we find an event, then wouldn't there have to be an issue? And if there is no event found, then there is no issue either? I don't think you'd ever have one without the other
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on the types returned by the event query, some events can have group=None. Idk when this happens in practice though
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #103787 +/- ##
============================================
+ Coverage 69.23% 80.62% +11.38%
============================================
Files 9273 9287 +14
Lines 395898 396487 +589
Branches 25247 25247
============================================
+ Hits 274111 319653 +45542
+ Misses 121327 76374 -44953
Partials 460 460 |

New rpc for AIML-1655: support issue_id=None in get_issue_details tool. This is a modified + renamed version of get_issue_details.
Tests todo, looking for feedback first