Skip to content

Conversation

@aliu39
Copy link
Member

@aliu39 aliu39 commented Nov 20, 2025

New rpc for AIML-1655: support issue_id=None in get_issue_details tool. This is a modified + renamed version of get_issue_details.

Tests todo, looking for feedback first

@aliu39 aliu39 requested a review from a team as a code owner November 20, 2025 22:53
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 20, 2025
Copy link
Member

@roaga roaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this works, but I'm curious what the use case is?

If it's because of discover, it's easy to get the issue column in our RPCs

Image

though then again I guess it can't hurt to have options. i would think that maybe we should just update our existing get_issue_details rpc than create a new one

@aliu39
Copy link
Member Author

aliu39 commented Nov 23, 2025

i think this works, but I'm curious what the use case is?

If it's because of discover, it's easy to get the issue column in our RPCs

Image

though then again I guess it can't hurt to have options. i would think that maybe we should just update our existing get_issue_details rpc than create a new one

Yup i thought it was just a nice option in case it's ever inconvenient to get the issue id. I made a new rpc just cuz i want to update the name - this is also our main tool for getting event details, and now you're allowed to pass just an event id, thought this appropriate

Copy link
Member

@roaga roaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok let's remember to clean up the old one

Returns:
A dict containing:
Issue fields (nullable iff issue_id is None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confused on this distinction between nullable and non nullable fields. If we find an event, then wouldn't there have to be an issue? And if there is no event found, then there is no issue either? I don't think you'd ever have one without the other

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on the types returned by the event query, some events can have group=None. Idk when this happens in practice though

@codecov
Copy link

codecov bot commented Nov 23, 2025

Codecov Report

❌ Patch coverage is 60.37736% with 21 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/seer/explorer/tools.py 60.37% 21 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           master   #103787       +/-   ##
============================================
+ Coverage   69.23%    80.62%   +11.38%     
============================================
  Files        9273      9287       +14     
  Lines      395898    396487      +589     
  Branches    25247     25247               
============================================
+ Hits       274111    319653    +45542     
+ Misses     121327     76374    -44953     
  Partials      460       460               

@aliu39 aliu39 merged commit 0cfb95d into master Nov 24, 2025
67 checks passed
@aliu39 aliu39 deleted the aliu/issue-none branch November 24, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants