-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix(dynamic-sampling): use options instead of feature flags for switching b/w span and transaction based rebalancing #102576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
shellmayr
merged 3 commits into
master
from
shellmayr/fix/use-options-for-dynamic-sampling-span-transaction-switching
Nov 5, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #102576 +/- ##
===========================================
+ Coverage 80.72% 80.91% +0.19%
===========================================
Files 8939 8939
Lines 391181 391178 -3
Branches 24883 24883
===========================================
+ Hits 315781 316523 +742
+ Misses 75030 74285 -745
Partials 370 370 |
obostjancic
approved these changes
Nov 4, 2025
…hing bw span and transaction based rebalancing
c75757f to
b1e7351
Compare
Contributor
|
PR reverted: 66f92d0 |
getsentry-bot
added a commit
that referenced
this pull request
Nov 5, 2025
…or switching b/w span and transaction based rebalancing (#102576)" This reverts commit 8ecceb3. Co-authored-by: shellmayr <[email protected]>
Member
Author
|
Reverted this because the jobs seemed to not cause things to get rebalanced anymore, some of the metrics were off. |
priscilawebdev
pushed a commit
that referenced
this pull request
Nov 6, 2025
…hing b/w span and transaction based rebalancing (#102576)
priscilawebdev
pushed a commit
that referenced
this pull request
Nov 6, 2025
…or switching b/w span and transaction based rebalancing (#102576)" This reverts commit 8ecceb3. Co-authored-by: shellmayr <[email protected]>
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
…hing b/w span and transaction based rebalancing (#102576)
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
…or switching b/w span and transaction based rebalancing (#102576)" This reverts commit 8ecceb3. Co-authored-by: shellmayr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Scope: Backend
Automatically applied to PRs that change backend components
Trigger: Revert
Add to a merged PR to revert it (skips CI)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to TET-1147