Skip to content

Conversation

@shellmayr
Copy link
Member

@shellmayr shellmayr commented Nov 3, 2025

  • Use an option with a list of orgs instead of feature flags because it's faster
  • Should be in-memory and therefore significantly faster than feature flags
  • We can do this because we do not expect large quantities of orgs to be added to this
  • Previous batch-checking solution had high performance penalty despite multiple optimizations

Contributes to TET-1147

@linear
Copy link

linear bot commented Nov 3, 2025

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 3, 2025
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/core/endpoints/organization_details.py 25.00% 3 Missing ⚠️
...ynamic_sampling/tasks/boost_low_volume_projects.py 76.92% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #102576      +/-   ##
===========================================
+ Coverage   80.72%    80.91%   +0.19%     
===========================================
  Files        8939      8939              
  Lines      391181    391178       -3     
  Branches    24883     24883              
===========================================
+ Hits       315781    316523     +742     
+ Misses      75030     74285     -745     
  Partials      370       370              

@shellmayr shellmayr changed the title fix(dynamic-sampling): use options instead of feature flags for switching bw span and transaction based rebalancing fix(dynamic-sampling): use options instead of feature flags for switching b/w span and transaction based rebalancing Nov 3, 2025
@shellmayr shellmayr marked this pull request as ready for review November 3, 2025 15:00
@shellmayr shellmayr requested a review from a team as a code owner November 3, 2025 15:00
@shellmayr shellmayr force-pushed the shellmayr/fix/use-options-for-dynamic-sampling-span-transaction-switching branch from c75757f to b1e7351 Compare November 5, 2025 08:20
@shellmayr shellmayr merged commit 8ecceb3 into master Nov 5, 2025
66 checks passed
@shellmayr shellmayr deleted the shellmayr/fix/use-options-for-dynamic-sampling-span-transaction-switching branch November 5, 2025 12:49
@shellmayr shellmayr added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Nov 5, 2025
@getsentry-bot
Copy link
Contributor

PR reverted: 66f92d0

getsentry-bot added a commit that referenced this pull request Nov 5, 2025
…or switching b/w span and transaction based rebalancing (#102576)"

This reverts commit 8ecceb3.

Co-authored-by: shellmayr <[email protected]>
@shellmayr
Copy link
Member Author

Reverted this because the jobs seemed to not cause things to get rebalanced anymore, some of the metrics were off.

priscilawebdev pushed a commit that referenced this pull request Nov 6, 2025
…hing b/w span and transaction based rebalancing (#102576)
priscilawebdev pushed a commit that referenced this pull request Nov 6, 2025
…or switching b/w span and transaction based rebalancing (#102576)"

This reverts commit 8ecceb3.

Co-authored-by: shellmayr <[email protected]>
Jesse-Box pushed a commit that referenced this pull request Nov 12, 2025
…hing b/w span and transaction based rebalancing (#102576)
Jesse-Box pushed a commit that referenced this pull request Nov 12, 2025
…or switching b/w span and transaction based rebalancing (#102576)"

This reverts commit 8ecceb3.

Co-authored-by: shellmayr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants