chore(eco): Cleans up old flag, old logic for Github webhook routing

[GabeVillalobos]

The new routing behavior has been live in production for the last week without any upticks in failures. Removing the old flag and logic now that it's been well-tested

[codecov]

❌ 8 Tests Failed:

Tests completed	Failed	Passed	Skipped
29680	8	29672	244

View the full list of 8 ❄️ flaky test(s)

tests.snuba.api.endpoints.test_organization_events_stats_trace_metrics.OrganizationEventsStatsTraceMetricsEndpointTest::test_meta_accuracy

Flake rate in main: 100.00% (Passed 0 times, Failed 6 times)

Stack Traces | 15.5s run time

#x1B[1m#x1B[.../api/endpoints/test_organization_events_stats_trace_metrics.py#x1B[0m:203: in test_meta_accuracy
    assert response.status_code == 200, response.content
#x1B[1m#x1B[31mE   AssertionError: b'{"detail":"Internal Error","errorId":null}'#x1B[0m
#x1B[1m#x1B[31mE   assert 500 == 200#x1B[0m
#x1B[1m#x1B[31mE    +  where 500 = <Response status_code=500, "application/json">.status_code#x1B[0m

tests.snuba.api.endpoints.test_organization_events_stats_trace_metrics.OrganizationEventsStatsTraceMetricsEndpointTest::test_per_second_function

Flake rate in main: 100.00% (Passed 0 times, Failed 7 times)

Stack Traces | 12.9s run time

#x1B[1m#x1B[.../api/endpoints/test_organization_events_stats_trace_metrics.py#x1B[0m:103: in test_per_second_function
    assert response.status_code == 200, response.content
#x1B[1m#x1B[31mE   AssertionError: b'{"detail":"Internal Error","errorId":null}'#x1B[0m
#x1B[1m#x1B[31mE   assert 500 == 200#x1B[0m
#x1B[1m#x1B[31mE    +  where 500 = <Response status_code=500, "application/json">.status_code#x1B[0m

tests.snuba.api.endpoints.test_organization_events_trace_metrics.OrganizationEventsTraceMetricsEndpointTest::test_aggregation_embedded_metric_name_formula

Flake rate in main: 100.00% (Passed 0 times, Failed 6 times)

Stack Traces | 17.6s run time

#x1B[1m#x1B[.../api/endpoints/test_organization_events_trace_metrics.py#x1B[0m:383: in test_aggregation_embedded_metric_name_formula
    assert response.status_code == 200, response.content
#x1B[1m#x1B[31mE   AssertionError: b'{"detail":"Internal Error","errorId":null}'#x1B[0m
#x1B[1m#x1B[31mE   assert 500 == 200#x1B[0m
#x1B[1m#x1B[31mE    +  where 500 = <Response status_code=500, "application/json">.status_code#x1B[0m

tests.snuba.api.endpoints.test_organization_events_trace_metrics.OrganizationEventsTraceMetricsEndpointTest::test_per_minute_formula

Flake rate in main: 100.00% (Passed 0 times, Failed 14 times)

Stack Traces | 17s run time

#x1B[1m#x1B[.../api/endpoints/test_organization_events_trace_metrics.py#x1B[0m:199: in test_per_minute_formula
    assert response.status_code == 200, response.content
#x1B[1m#x1B[31mE   AssertionError: b'{"detail":"Internal Error","errorId":null}'#x1B[0m
#x1B[1m#x1B[31mE   assert 500 == 200#x1B[0m
#x1B[1m#x1B[31mE    +  where 500 = <Response status_code=500, "application/json">.status_code#x1B[0m

tests.snuba.api.endpoints.test_organization_events_trace_metrics.OrganizationEventsTraceMetricsEndpointTest::test_per_second_formula

Flake rate in main: 100.00% (Passed 0 times, Failed 11 times)

Stack Traces | 15.8s run time

#x1B[1m#x1B[.../api/endpoints/test_organization_events_trace_metrics.py#x1B[0m:223: in test_per_second_formula
    assert response.status_code == 200, response.content
#x1B[1m#x1B[31mE   AssertionError: b'{"detail":"Internal Error","errorId":null}'#x1B[0m
#x1B[1m#x1B[31mE   assert 500 == 200#x1B[0m
#x1B[1m#x1B[31mE    +  where 500 = <Response status_code=500, "application/json">.status_code#x1B[0m

tests.snuba.api.endpoints.test_organization_events_trace_metrics.OrganizationEventsTraceMetricsEndpointTest::test_per_second_formula_with_counter_metric_type

Flake rate in main: 100.00% (Passed 0 times, Failed 5 times)

Stack Traces | 15.3s run time

#x1B[1m#x1B[.../api/endpoints/test_organization_events_trace_metrics.py#x1B[0m:250: in test_per_second_formula_with_counter_metric_type
    assert response.status_code == 200, response.content
#x1B[1m#x1B[31mE   AssertionError: b'{"detail":"Internal Error","errorId":null}'#x1B[0m
#x1B[1m#x1B[31mE   assert 500 == 200#x1B[0m
#x1B[1m#x1B[31mE    +  where 500 = <Response status_code=500, "application/json">.status_code#x1B[0m

tests.snuba.api.endpoints.test_organization_events_trace_metrics.OrganizationEventsTraceMetricsEndpointTest::test_per_second_formula_with_gauge_metric_type

Flake rate in main: 100.00% (Passed 0 times, Failed 7 times)

Stack Traces | 12.6s run time

#x1B[1m#x1B[.../api/endpoints/test_organization_events_trace_metrics.py#x1B[0m:275: in test_per_second_formula_with_gauge_metric_type
    assert response.status_code == 200, response.content
#x1B[1m#x1B[31mE   AssertionError: b'{"detail":"Internal Error","errorId":null}'#x1B[0m
#x1B[1m#x1B[31mE   assert 500 == 200#x1B[0m
#x1B[1m#x1B[31mE    +  where 500 = <Response status_code=500, "application/json">.status_code#x1B[0m

tests.snuba.api.endpoints.test_organization_events_trace_metrics.OrganizationEventsTraceMetricsEndpointTest::test_per_second_formula_with_gauge_metric_type_without_top_level_metric_type

Flake rate in main: 100.00% (Passed 0 times, Failed 4 times)

Stack Traces | 15.1s run time

#x1B[1m#x1B[.../api/endpoints/test_organization_events_trace_metrics.py#x1B[0m:299: in test_per_second_formula_with_gauge_metric_type_without_top_level_metric_type
    assert response.status_code == 200, response.content
#x1B[1m#x1B[31mE   AssertionError: b'{"detail":"Internal Error","errorId":null}'#x1B[0m
#x1B[1m#x1B[31mE   assert 500 == 200#x1B[0m
#x1B[1m#x1B[31mE    +  where 500 = <Response status_code=500, "application/json">.status_code#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[cathteng]

rawr