fix(billing): Fix credit card expiration date display #103112
Merged
+37
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace timezone-dependent Date/moment formatting with direct string formatting to ensure expiration dates display correctly for all users regardless of browser or account timezone settings. Previous implementation created Date objects at browser-local midnight and formatted them using the user's account timezone preference (set via moment.tz.setDefault), causing month shifts when browser timezone was ahead of account timezone.
github-actions
bot
added
the
Scope: Frontend
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace timezone-dependent Date/moment formatting with direct string formatting to ensure expiration dates display correctly for all users regardless of browser or account timezone settings.
Previous implementation created Date objects at browser-local midnight and formatted them using the user's account timezone preference (set via moment.tz.setDefault), causing month shifts when browser timezone was ahead of account timezone.
Root cause:
sentry/static/gsApp/components/creditCardEdit/panel.tsx
Line 192 in 08aa2d8
new Date(2030, 7)in the browser's local timezone. Somoment()will parse Date objects in the browser's local timezone.moment.tz.setDefault(userTimeZone);using the user's timezone preferences (populated from backend)sentry/static/app/stores/configStore.tsx
Line 64 in 08aa2d8