Fix clipped text in installer (#658)

My adjustments in #655 worked in my tests, at zoom level 125%. But they
do not work at any other zoom level, causing clipped text and awful
layout.

Here, I present the end result of iterating until I ended up with a much
simpler solution than I had originally come up with (and which
unfortunately made it into the Git for Windows v2.52.0 installer).

This fixes git-for-windows/git#5961

Author: dscho

installer/install.iss

@@ -1459,7 +1459,7 @@ function CreateItemDescription(Page:TWizardPage;const Description:String;var Top
 var
     SubLabel:TLabel;
     Untagged,RowPrefix,Link:String;
-    RowStart,RowCount,RowHeight,i,j:Integer;
+    RowStart,RowCount,i,j:Integer;
 begin
     Untagged:='';
     Result:=TLabel.Create(Page);
@@ -1468,30 +1468,25 @@ begin
     Result.Top:=ScaleY(Top);
     Result.Left:=ScaleX(Left+24);
     Result.Width:=ScaleX(405);
-    Result.Height:=ScaleY(13);
     Result.Visible:=Visible;
     SetArrayLength(Labels,GetArrayLength(Labels)+1);
     Labels[GetArrayLength(Labels)-1]:=Result;
     RowPrefix:='';
     RowCount:=1;
-    RowHeight:=Result.Font.Height;
-    if (RowHeight<0) then
-        RowHeight:=-RowHeight;
     while True do begin
         case Pos3(Description,#13,'<RED>','<A HREF=',i) of
             '': begin
                 Untagged:=Untagged+Description;
                 Result.Caption:=Untagged;
-                Result.Height:=ScaleY(RowHeight*RowCount);
-                Top:=Top+RowHeight+18;
+                Top:=Top+15+18;
                 Exit;
             end;
             ''+#13: begin
                 Untagged:=Untagged+SubString(Description,1,i);
                 Description:=SubString(Description,i+1,-1);
                 RowCount:=RowCount+1;
                 RowPrefix:='';
-                Top:=Top+RowHeight;
+                Top:=Top+15;
             end;
             '<RED>': begin
                 Untagged:=Untagged+SubString(Description,1,i-1);
@@ -1510,14 +1505,13 @@ begin
                     SubLabel.Top:=ScaleY(Top);
                     SubLabel.Left:=GetTextWidth(RowPrefix,Result.Font)+ScaleX(Left+24);
                     SubLabel.Width:=ScaleX(405);
-                    SubLabel.Height:=ScaleY(RowHeight);
                     SubLabel.Font.Color:=clRed;
                     SubLabel.Visible:=Visible;
                     Untagged:=Untagged+SubString(Description,1,j);
                     Description:=SubString(Description,j+1,-1);
                     i:=i-j;
                     RowPrefix:='';
-                    Top:=Top+RowHeight;
+                    Top:=Top+13;
                     RowCount:=RowCount+1;
                     SetArrayLength(Labels,GetArrayLength(Labels)+1);
                     Labels[GetArrayLength(Labels)-1]:=SubLabel;
@@ -1528,7 +1522,6 @@ begin
                 SubLabel.Top:=ScaleY(Top);
                 SubLabel.Left:=GetTextWidth(RowPrefix,Result.Font)+ScaleX(Left+24);
                 SubLabel.Width:=ScaleX(405);
-                SubLabel.Height:=ScaleY(RowHeight*CountLines(SubLabel.Caption));
                 SubLabel.Font.Color:=clRed;
                 SubLabel.Visible:=Visible;
                 Untagged:=Untagged+SubString(Description,1,i-1);
@@ -1566,7 +1559,6 @@ begin
                     SubLabel.Top:=ScaleY(Top);
                     SubLabel.Left:=GetTextWidth(RowPrefix,Result.Font)+ScaleX(Left+24);
                     SubLabel.Width:=ScaleX(405);
-                    SubLabel.Height:=ScaleY(RowHeight);
                     SubLabel.Font.Color:=clBlue;
                     SubLabel.Font.Style:=[fsUnderline];
                     SubLabel.Cursor:=crHand;
@@ -1576,7 +1568,7 @@ begin
                     Description:=SubString(Description,j+1,-1);
                     i:=i-j;
                     RowPrefix:='';
-                    Top:=Top+RowHeight;
+                    Top:=Top+13;
                     RowCount:=RowCount+1;
                     SetArrayLength(Labels,GetArrayLength(Labels)+1);
                     Labels[GetArrayLength(Labels)-1]:=SubLabel;
@@ -1588,7 +1580,6 @@ begin
                 SubLabel.Top:=ScaleY(Top);
                 SubLabel.Left:=GetTextWidth(RowPrefix,Result.Font)+ScaleX(Left+24);
                 SubLabel.Width:=ScaleX(405);
-                SubLabel.Height:=ScaleY(RowHeight*CountLines(SubLabel.Caption));
                 SubLabel.Font.Color:=clBlue;
                 SubLabel.Font.Style:=[fsUnderline];
                 SubLabel.Cursor:=crHand;