installer: fix rendering of red text and links

According to https://jrsoftware.github.io/issrc/whatsnew.htm, the
default `DialogFontBaseScaleHeight` (which used to be 13) has changed.
We need to accommodate for that change so that the red text and the
links overlay the unstyled text again.

Signed-off-by: Johannes Schindelin <[email protected]>

Author: dscho

installer/install.iss

@@ -1459,7 +1459,7 @@ function CreateItemDescription(Page:TWizardPage;const Description:String;var Top
 var
     SubLabel:TLabel;
     Untagged,RowPrefix,Link:String;
-    RowStart,RowCount,i,j:Integer;
+    RowStart,RowCount,RowHeight,i,j:Integer;
 begin
     Untagged:='';
     Result:=TLabel.Create(Page);
@@ -1474,21 +1474,22 @@ begin
     Labels[GetArrayLength(Labels)-1]:=Result;
     RowPrefix:='';
     RowCount:=1;
+    RowHeight:=15;
     while True do begin
         case Pos3(Description,#13,'<RED>','<A HREF=',i) of
             '': begin
                 Untagged:=Untagged+Description;
                 Result.Caption:=Untagged;
-                Result.Height:=ScaleY(13*RowCount);
-                Top:=Top+13+18;
+                Result.Height:=ScaleY(RowHeight*RowCount);
+                Top:=Top+RowHeight+18;
                 Exit;
             end;
             ''+#13: begin
                 Untagged:=Untagged+SubString(Description,1,i);
                 Description:=SubString(Description,i+1,-1);
                 RowCount:=RowCount+1;
                 RowPrefix:='';
-                Top:=Top+13;
+                Top:=Top+RowHeight;
             end;
             '<RED>': begin
                 Untagged:=Untagged+SubString(Description,1,i-1);
@@ -1507,14 +1508,14 @@ begin
                     SubLabel.Top:=ScaleY(Top);
                     SubLabel.Left:=GetTextWidth(RowPrefix,Result.Font)+ScaleX(Left+24);
                     SubLabel.Width:=ScaleX(405);
-                    SubLabel.Height:=ScaleY(13);
+                    SubLabel.Height:=ScaleY(RowHeight);
                     SubLabel.Font.Color:=clRed;
                     SubLabel.Visible:=Visible;
                     Untagged:=Untagged+SubString(Description,1,j);
                     Description:=SubString(Description,j+1,-1);
                     i:=i-j;
                     RowPrefix:='';
-                    Top:=Top+13;
+                    Top:=Top+RowHeight;
                     RowCount:=RowCount+1;
                     SetArrayLength(Labels,GetArrayLength(Labels)+1);
                     Labels[GetArrayLength(Labels)-1]:=SubLabel;
@@ -1525,7 +1526,7 @@ begin
                 SubLabel.Top:=ScaleY(Top);
                 SubLabel.Left:=GetTextWidth(RowPrefix,Result.Font)+ScaleX(Left+24);
                 SubLabel.Width:=ScaleX(405);
-                SubLabel.Height:=ScaleY(13*CountLines(SubLabel.Caption));
+                SubLabel.Height:=ScaleY(RowHeight*CountLines(SubLabel.Caption));
                 SubLabel.Font.Color:=clRed;
                 SubLabel.Visible:=Visible;
                 Untagged:=Untagged+SubString(Description,1,i-1);
@@ -1563,7 +1564,7 @@ begin
                     SubLabel.Top:=ScaleY(Top);
                     SubLabel.Left:=GetTextWidth(RowPrefix,Result.Font)+ScaleX(Left+24);
                     SubLabel.Width:=ScaleX(405);
-                    SubLabel.Height:=ScaleY(13);
+                    SubLabel.Height:=ScaleY(RowHeight);
                     SubLabel.Font.Color:=clBlue;
                     SubLabel.Font.Style:=[fsUnderline];
                     SubLabel.Cursor:=crHand;
@@ -1573,7 +1574,7 @@ begin
                     Description:=SubString(Description,j+1,-1);
                     i:=i-j;
                     RowPrefix:='';
-                    Top:=Top+13;
+                    Top:=Top+RowHeight;
                     RowCount:=RowCount+1;
                     SetArrayLength(Labels,GetArrayLength(Labels)+1);
                     Labels[GetArrayLength(Labels)-1]:=SubLabel;
@@ -1585,7 +1586,7 @@ begin
                 SubLabel.Top:=ScaleY(Top);
                 SubLabel.Left:=GetTextWidth(RowPrefix,Result.Font)+ScaleX(Left+24);
                 SubLabel.Width:=ScaleX(405);
-                SubLabel.Height:=ScaleY(13*CountLines(SubLabel.Caption));
+                SubLabel.Height:=ScaleY(RowHeight*CountLines(SubLabel.Caption));
                 SubLabel.Font.Color:=clBlue;
                 SubLabel.Font.Style:=[fsUnderline];
                 SubLabel.Cursor:=crHand;