Console Freezes with tab on empty line.

[red-ornob]

• I was not able to find an open or closed issue matching what I'm seeing

Setup

• Which version of Git for Windows are you using? Is it 32-bit or 64-bit?

$ git --version --build-options

git version 2.47.1.windows.1
cpu: x86_64
built from commit: 2cd22437f64229935dc564db969cbcbfed5e9045
sizeof-long: 4
sizeof-size_t: 8
shell-path: D:/git-sdk-64-build-installers/usr/bin/sh
feature: fsmonitor--daemon
libcurl: 8.11.0
OpenSSL: OpenSSL 3.2.3 3 Sep 2024
zlib: 1.3.1

• Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?

$ cmd.exe /c ver

Microsoft Windows [Version 10.0.22631.4541]

• What options did you set as part of the installation? Or did you choose the
  defaults?

$ cat /etc/install-options.txt

Editor Option: Nano
Custom Editor Path: 
Default Branch Option: main
Path Option: Cmd
SSH Option: OpenSSH
Tortoise Option: false
CURL Option: OpenSSL
CRLF Option: CRLFAlways
Bash Terminal Option: ConHost
Git Pull Behavior Option: Merge
Use Credential Manager: Enabled
Performance Tweaks FSCache: Enabled
Enable Symlinks: Enabled
Enable FSMonitor: Disabled

• Any other interesting things about your environment that might be related
  to the issue you're seeing?

Not in my judgement.

Details

• Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

Bash running in the Terminal app. [But the installation does say it uses the cmd.exe console]
Not fully sure what the question is asking tbh.

• What commands did you run to trigger this issue? If you can provide a
  Minimal, Complete, and Verifiable example
  this will help us understand the issue.

Using tab on an empty line.

• What did you expect to occur after running these commands?

Nothing.

• What actually happened instead?

Terminal tab Freezes and stops responding, seems to be similar to #4945.
Ctrl+C does not work.
It does this

• If the problem was occurring with a specific repository, can you provide the
  URL to that repository to help us with testing?

No.

[dscho]

This looks like code completion is taking a long time, and doing this on an empty line this does not surprise me.

[dscho]

Closing this issue because it has become stale.

[davidalayachew]

@dscho -- Can we reopen the issue? The real problem is that there is no way I can see to stop this freeze/hang. Or if there is, a comment explaining how would be helpful.

It would be best if this could be cancelled with Ctrl+c, as that's how we cancel most everything else on Git Bash. Otherwise, I have to wait up to 20 seconds.

[davidalayachew]

Worse yet, this is fairly easy to stumble upon unintentionally. Sometimes, I mean to press tab, then enter. But I accidentally press enter then tab, causing this exact issue. 5-20 seconds lost each time.

[davidalayachew]

Wow, silly me. We can just use shopt -s no_empty_cmd_completion to completely disable autocomplete only on empty lines, thus, side-stepping this problem completely.

Special thanks to the sharp minds on StackExchanges SuperUser forum. Here is the specific answer -- https://superuser.com/a/1930267/1678242

Please be kind and upvote them if their answer solved your problem too.

[dscho]

@davidalayachew how about adding this command to /etc/profile.d/git-prompt.sh?

[davidalayachew]

@davidalayachew how about adding this command to /etc/profile.d/git-prompt.sh?

I'm not very good at reading shell, but the idea sounds great to me! This is a reasonable default imo.

However, would this command make more sense in like a bashrc file or equivalent? I am pretty sure that bashrc is not created by default in Git Bash, but some other equivalent file?

I only suggest this because it may not be wise for users who want to turn this off to go digging into a file as internal as this. Best to add this somewhere where it can be easily added/removed.

[dscho]

would this command make more sense in like a bashrc file or equivalent?

There is an /etc/bash.bashrc, but it is owned by the filesystem, which is under MSYS2's control, not Git for Windows'.

There is also /etc/profile.d/bash_profile.sh which ensures that a ~/.bashrc is installed if the user has none, but that feels like a fragile vehicle to get this to the Git for Windows users.

I only suggest this because it may not be wise for users who want to turn this off to go digging into a file as internal as this. Best to add this somewhere where it can be easily added/removed.

It can be disabled easily (even if this is not exactly obvious) in ~/.bashrc via shopt -u no_empty_cmd_completion.

Maybe as a compromise add the command to /etc/profile.d/git-prompt.sh, with a comment explaining how to override this in ~/.bashrc?

[davidalayachew]

It can be disabled easily (even if this is not exactly obvious) in ~/.bashrc via shopt -u no_empty_cmd_completion.

Ah, ok. I was unfamiliar with the order of operations.

I was under the assumption that that script got run each time you did an autocomplete, or something like that. Thus, my fear was that you truly would have to edit this file if you wanted to undo that.

But no, if the bashrc file is run after this, and thus, totally overrides this, then that is much better.

Maybe as a compromise add the command to /etc/profile.d/git-prompt.sh, with a comment explaining how to override this in ~/.bashrc?

Deal. Thanks for being flexible on this.

[dscho]

@davidalayachew would you kindly make the change, condense our discussion into a complete commit message and open a PR?

[davidalayachew]

Deal. Will do after work today.

[davidalayachew]

Done. Not sure why the GitHub Actions are failing. Am I doing something wrong?

git-for-windows/build-extra#657