Skip to content

Commit 8bd00b3

Browse files
committed
Adapt release script hide away Ubuntu noble builds
1 parent 2714df9 commit 8bd00b3

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

scripts/release.sh

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -227,11 +227,15 @@ else
227227
BUNDLE_DIR=$(readlink -f "$PWD/../target/release/bundle")
228228
fi
229229

230-
# The release dir determines a (significant portion of) the final S3 object key.
230+
# The release dir determines a (significant portion of) the S3 object keys for
231+
# the artifacts.
231232
RELEASE_DIR="$DIST/$OS/$ARCH"
232-
if [ "$OS" = "linux" ]; then
233-
# We build for multiple linux distros and need distinct keys for them.
234-
RELEASE_DIR="$DIST/$OS/$(lsb_release -cs)/$ARCH"
233+
if [ "$OS" = "linux" ] && [ $(lsb_release -cs) = "noble" ]; then
234+
# Our default Linux build is Ubuntu jammy (22.04). We still build for noble
235+
# (24.04) but put the builds in a hidden-away part of the S3 bucket. The
236+
# primary reason for this build existing is that the noble-built AppImage
237+
# tends to work better with newer distros than the jammy-built AppImage.
238+
RELEASE_DIR="$DIST/$OS-$(lsb_release -cs)/$ARCH"
235239
fi
236240

237241
echo "Resolved RELEASE_DIR=$RELEASE_DIR"

0 commit comments

Comments
 (0)