Python: Fix isType false positive on modules named *typing (fixes #22621)

Author: ShivamNayak-dev

python/ql/lib/semmle/python/objects/TObject.qll

@@ -216,7 +216,9 @@ private predicate scope_loads_tuplenode(Scope s, TupleNode origin) {
 predicate isType(ObjectInternal t) {
   t.isClass() = true
   or
-  t.getOrigin().getEnclosingModule().getName().matches("%typing")
+  exists(string name | name = t.getOrigin().getEnclosingModule().getName() |
+    name = "typing" or name = "typing_extensions" or name.matches("typing.%")
+  )
 }
 
 private predicate is_power_2(int n) {

python/ql/test/library-tests/PointsTo/regressions/typing-filename/Test.expected

@@ -0,0 +1 @@
+| main.py:6:1:6:13 | ControlFlowNode for InTyping() | resolved: InTyping() |

python/ql/test/library-tests/PointsTo/regressions/typing-filename/Test.ql

@@ -0,0 +1,12 @@
+import python
+private import LegacyPointsTo
+
+from ControlFlowNodeWithPointsTo use, string outcome
+where
+  exists(CallNode call | call.getFunction().(NameNode).getId() = "InTyping" and use = call) and
+  (
+    if exists(use.pointsTo())
+    then outcome = "resolved: " + use.pointsTo().toString()
+    else outcome = "no points-to info"
+  )
+select use, outcome

python/ql/test/library-tests/PointsTo/regressions/typing-filename/main.py

@@ -0,0 +1,10 @@
+from typing import Optional
+
+from pkg.other import InOther
+from pkg.typing import InTyping
+
+InTyping("a")
+Optional[InTyping]
+
+InOther("b")
+Optional[InOther]

python/ql/test/library-tests/PointsTo/regressions/typing-filename/pkg/__init__.py

@@ -0,0 +1,15 @@
+registry = {}
+
+
+def make_type(name):
+    if name in registry:
+        return registry[name]
+
+    class Created(str):
+        pass
+
+    registry[name] = Created
+    return Created
+
+
+InTyping = make_type("InTyping")

python/ql/test/library-tests/PointsTo/regressions/typing-filename/pkg/other.py

@@ -0,0 +1,15 @@
+registry = {}
+
+
+def make_type(name):
+    if name in registry:
+        return registry[name]
+
+    class Created(str):
+        pass
+
+    registry[name] = Created
+    return Created
+
+
+InOther = make_type("InOther")

python/ql/test/library-tests/PointsTo/regressions/typing-filename/pkg/typing.py

@@ -0,0 +1,15 @@
+registry = {}
+
+
+def make_type(name):
+    if name in registry:
+        return registry[name]
+
+    class Created(str):
+        pass
+
+    registry[name] = Created
+    return Created
+
+
+InTyping = make_type("InTyping")