Skip to content

Commit 3a7f851

Browse files
committed
Fix AnyAttr thing
1 parent 0e6d439 commit 3a7f851

245 files changed

Lines changed: 1473 additions & 1122 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎rust/ast-generator/src/main.rs‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,6 @@ fn should_node_be_skipped(name: &str) -> bool {
8080

8181
fn should_node_be_skipped_in_extractor(name: &str) -> bool {
8282
name == "Adt" // no fields have `Adt` type, so we don't need extraction for it
83-
|| name == "AnyAttr" // no fields have `AnyAttr` type
84-
|| name == "DocComment" // doc comments are not extracted yet
8583
}
8684

8785
fn should_field_be_skipped(node_name: &str, field_name: &str) -> bool {
@@ -151,7 +149,7 @@ fn get_additional_fields(node_name: &str) -> Vec<FieldInfo> {
151149

152150
fn get_trait_fields(trait_name: &str) -> Vec<FieldInfo> {
153151
match trait_name {
154-
"HasAttrs" => vec![FieldInfo::list("attrs", "Attr")],
152+
"HasAttrs" => vec![FieldInfo::list("attrs", "AnyAttr")],
155153
"HasName" => vec![FieldInfo::optional("name", "Name")],
156154
"HasVisibility" => vec![FieldInfo::optional("visibility", "Visibility")],
157155
"HasGenericParams" => vec![
@@ -442,7 +440,11 @@ fn field_info_to_extractor_info(name: &str, field: &FieldInfo) -> ExtractorNodeF
442440
},
443441
FieldType::List(ty) => ExtractorNodeFieldInfo {
444442
name,
445-
method: field.name.clone(),
443+
method: if ty == "AnyAttr" {
444+
"attrs_with_doc".to_owned()
445+
} else {
446+
field.name.clone()
447+
},
446448
snake_case_ty: to_lower_snake_case(ty),
447449
list: true,
448450
..Default::default()

‎rust/extractor/src/generated/.generated.list‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)