Python: Rename otherArgs to implicitArgumentNode

tausbn · yoff · tausbn · commit 62fb38d8343e · 2026-02-03T15:32:46.000Z
Co-authored-by: yoff &lt;yoff@github.com&gt;
diff --git a/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPublic.qll b/python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPublic.qll
@@ -369,7 +369,7 @@ Node getCallArgApproximation() {
 }
 
 /** Gets the extracted argument nodes that do not rely on `getCallArg`. */
-private Node otherArgs() {
+private Node implicitArgumentNode() {
   // for potential summaries we allow all normal call arguments
   normalCallArg(_, result, _)
   or
@@ -387,14 +387,14 @@ class ExtractedArgumentNode extends ArgumentNode {
   ExtractedArgumentNode() {
     this = getCallArgApproximation()
     or
-    this = otherArgs()
+    this = implicitArgumentNode()
   }
 
   final override predicate argumentOf(DataFlowCall call, ArgumentPosition pos) {
     this = call.getArgument(pos) and
     call instanceof ExtractedDataFlowCall and
     (
-      this = otherArgs()
+      this = implicitArgumentNode()
       or
       this = getCallArgApproximation() and getCallArg(_, _, _, this, _)
     )

Original file line number	Diff line number	Diff line change
`@@ -369,7 +369,7 @@ Node getCallArgApproximation() {`
`369`	`369`	`}`
`370`	`370`
`371`	`371`	/** Gets the extracted argument nodes that do not rely on `getCallArg`. */
`372`		`-private Node otherArgs() {`
	`372`	`+private Node implicitArgumentNode() {`
`373`	`373`	`// for potential summaries we allow all normal call arguments`
`374`	`374`	`normalCallArg(_, result, _)`
`375`	`375`	`or`
`@@ -387,14 +387,14 @@ class ExtractedArgumentNode extends ArgumentNode {`
`387`	`387`	`ExtractedArgumentNode() {`
`388`	`388`	`this = getCallArgApproximation()`
`389`	`389`	`or`
`390`		`- this = otherArgs()`
	`390`	`+ this = implicitArgumentNode()`
`391`	`391`	`}`
`392`	`392`
`393`	`393`	`final override predicate argumentOf(DataFlowCall call, ArgumentPosition pos) {`
`394`	`394`	`this = call.getArgument(pos) and`
`395`	`395`	`call instanceof ExtractedDataFlowCall and`
`396`	`396`	`(`
`397`		`- this = otherArgs()`
	`397`	`+ this = implicitArgumentNode()`
`398`	`398`	`or`
`399`	`399`	`this = getCallArgApproximation() and getCallArg(_, _, _, this, _)`
`400`	`400`	`)`