[lint-monster] Daily Lint Scan Report — 2026-05-16 — Custom Linter Findings

[github-actions[bot]]

Summary

Daily custom linter scan (make golint-custom) detected 2,413 lint findings across the gh-aw codebase:

• 2,391 findings: Functions exceeding 60-line limit
• 22 findings: Functions exceeding 8-parameter limit

No findings in pre-check flag file — proceeding with remediation.

Grouping Strategy

Issues grouped into three agent-assigned tasks by subsystem/complexity:

Group 1: CLI & Utility Refactoring (~800 findings)

Assigned: #XXX - Lint Remediation: CLI & Utility Refactoring (Group 1/3)

Scope:

• pkg/cli/ - 12+ CLI functions with 9-19 parameters and excessive line length
• pkg/console/ - 4+ rendering functions (67-98 lines)
• pkg/stringutil/ - 2+ utility functions (74-88 lines)

Largest findings:

1. pkg/cli/logs_orchestrator.go:689 - DownloadWorkflowLogsFromStdin (19 params)
2. pkg/cli/compile_workflow_processor.go:49 - compileWorkflowFile (11 params)
3. pkg/cli/includes.go:170 - fetchFrontmatterImportsRecursive (11 params)
4. pkg/console/render.go:442 - formatFieldValueWithTag (98 lines)

Remediation approach: Options struct pattern for parameter overload; helper extraction for line length

---

Group 2: Parser Infrastructure (~900 findings)

Assigned: #XXX - Lint Remediation: Parser Infrastructure (Group 2/3)

Scope:

• pkg/parser/ - ~50+ functions with excessive line length (62-599 lines), including MCP, import, and include processing
• pkg/actionpins/ - 1+ function with excessive line length

Critical longest functions (Phase 1 priority):

1. pkg/parser/frontmatter_extraction_yaml.go:107 - commentOutProcessedFieldsInOnSection (599 lines) — LARGEST
2. pkg/parser/import_bfs.go:21 - processImportsFromFrontmatterWithManifestAndSource (492 lines)
3. pkg/parser/schedule_fuzzy_scatter.go:184 - ScatterSchedule (441 lines)
4. pkg/parser/mcp.go:484 - ParseMCPConfig (253 lines)
5. pkg/parser/mcp.go:255 - processBuiltinMCPTool (225 lines)

Remediation approach: Phased decomposition (ultra-long >250L → long 100-250L → moderate 60-100L); extraction into helper functions with test coverage

---

Group 3: Workflow Compilation (~600 findings)

Assigned: #XXX - Lint Remediation: Workflow Compilation (Group 3/3)

Scope:

• pkg/workflow/ - ~100+ functions with excessive line length (63-486 lines) concentrated in compiler and engine modules
• 22+ functions with >8 parameters (9-12 parameters)

Critical functions (Phase 1 priority):

1. pkg/workflow/compiler_pre_activation_job.go:20 - buildPreActivationJob (486 lines)
2. pkg/workflow/copilot_engine_execution.go:41 - GetExecutionSteps (470 lines)
3. pkg/workflow/compiler_orchestrator_engine.go:35 - setupEngineAndImports (391 lines)
4. pkg/workflow/claude_engine.go:119 - GetExecutionSteps (372 lines)
5. pkg/workflow/compiler_main_job.go:26 - buildMainJob (333 lines)

Remediation approach: Engine step extraction (highest impact); orchestrator decomposition; options struct for parameter overload

---

Findings Distribution by Package

Package	Issue Count	Largest Function	Strategy
pkg/workflow/	~600	buildPreActivationJob (486L)	Engine extraction, orchestrator refactoring
pkg/parser/	~900	commentOutProcessedFieldsInOnSection (599L)	Phased ultra-long decomposition
pkg/cli/	~600	DownloadWorkflowLogsFromStdin (19p)	Options struct, helper extraction
pkg/console/	~100	formatFieldValueWithTag (98L)	Helper extraction
pkg/actionpins/	~10	ResolveActionPin (105L)	Helper extraction
pkg/stringutil/	~50	StripANSI (88L), SanitizeName (74L)	Helper extraction
Other packages	~50	Various	Case-by-case
TOTAL	~2,413	commentOutProcessedFieldsInOnSection	3 parallel agent tasks

Assignment Status

• ✅ Group 1 — Assigned to Copilot agent
• ✅ Group 2 — Assigned to Copilot agent
• ✅ Group 3 — Assigned to Copilot agent

Skill Recommendations

Agents should reference:

• developer skill — Go code organization, refactoring patterns, function decomposition
• error-messages skill — Maintaining validation error boundaries during refactoring
• Existing codebase helpers — Naming conventions, validation patterns

Success Criteria

✅ All 2,413 findings resolved across three groups
✅ All unit tests pass
✅ Workflow compilation produces correct YAML
✅ No behavioral regressions
✅ Code remains functionally equivalent

Estimated Timeline: 2-3 agent sessions per group (large, complex refactoring)

---

Report generated by LintMonster daily orchestrator

Generated by 🧌 LintMonster · ● 573.9K · ◷

• expires on May 18, 2026, 9:19 PM UTC

[github-actions[bot]]

This discussion has been marked as outdated by LintMonster.

A newer discussion is available at Discussion #32740.