Skip to content

[KISS] system url function helper : no urldecode #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sudwebdesign wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[KISS] system url function helper : no urldecode #308

sudwebdesign wants to merge 1 commit into from

Conversation

@sudwebdesign
Copy link

@sudwebdesign sudwebdesign commented Jun 3, 2025 •
edited
Loading

See Notification Tag saved in french
Bug: Tag enregistré !

Screenshot 2025-06-03 at 01-36-36 Vvveb - Notification Tag saved html entities error

Fix: Tag enregistré !

Screenshot 2025-06-03 at 01-39-05 Vvveb - Notification Tag saved html entities Fix OK

Sometime less is more... & Think K.I.S.S.

Note: not fully tested with all marvelous possibilities of Vvveb...
I share this commit just in case.

N.B.:

Tested to replace urldecode with urlencode but fail in numerous link (edit/design btns)

@sudwebdesign
[Fix] system url function show html entities in notifications
bdae995 
See Notification Tag saved in french
Bug: Tag enregistré !
Fix: Tag enregistré !

Sometime less is more...
@sudwebdesign
Copy link
Author

sudwebdesign commented Jun 3, 2025 •
edited
Loading

Maybe this is a bad fix note: the notification html entity become only when save a new tag

after givanz/vvveb-admin-template#3 & #307 (in my case)

After save a new TAG redirect to admin/index.php?module=content/tag&taxonomy_item_id=13&taxonomy_id=5&type=product&success=Tag enregistré%C2%A0! and after save with (same) url Vvveb show twice notification:

Screenshot 2025-06-03 at 01-36-36 Vvveb - 2 Notifications new Tag resaved

With this PR or not !

How to reproduce

  • Add a new tag > save (One notification) > (Re)Save (two notifiactions) 1st from url & 2nd from controller

@sudwebdesign sudwebdesign mentioned this pull request Jun 3, 2025
Open
@sudwebdesign sudwebdesign reopened this Jun 3, 2025
@sudwebdesign
Copy link
Author

sudwebdesign commented Jun 3, 2025

Reopened because after little test nothing go wrong (for the moment...)

I continue the tests

@sudwebdesign sudwebdesign changed the title [Fix] system url function show html entities in notifications [KISS] system url function helper : no urldecode Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sudwebdesign