Merge pull request #877 from globocom/feat/mysql_expire_bin_log

Fixed expire bin log when database stopped more days than expire_bin_log

Author: nimbfire

dbaas/drivers/replication_topologies/base.py

@@ -724,6 +724,7 @@ def get_stop_database_vm_steps(self):
                 'workflow.steps.util.database.checkAndFixMySQLReplication',
             )}, {
             'Stopping database': (
+                'workflow.steps.util.mysql.SaveMysqlBinlog',
                 'workflow.steps.util.database.Stop',
                 'workflow.steps.util.database.StopRsyslog',
                 'workflow.steps.util.database.CheckIsDown',

dbaas/workflow/steps/util/mysql.py

@@ -227,7 +227,19 @@ def do(self):
 
         driver = self.infra.get_driver()
         client = driver.get_client(self.instance)
-        mysql_binlog_save(client, self.instance)
+
+
+class SaveMySqlBinlog(MySQLStep):
+
+    def __unicode__(self):
+        return "Saving binlog position to stop database..."
+
+    def do(self):
+        driver = self.infra.get_driver()
+        client = driver.get_client(self.instance)
+
+        if 'MySQL' in type(driver).__name__:
+            mysql_binlog_save(client, self.instance)
 
 
 class RestoreSnapshotMySQL(RestoreSnapshot):