Skip to content

Conversation

@ajnavarro
Copy link
Contributor

We got some unexpected empty fields. Covering all the cases where this might happen.

Signed-off-by: Antonio Navarro Perez <[email protected]>
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Oct 20, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: ajnavarro/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

❌ Patch coverage is 20.58824% with 27 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
contribs/gnofaucet/github/api.go 0.00% 12 Missing and 3 partials ⚠️
contribs/gnofaucet/github/fetcher.go 36.84% 8 Missing and 4 partials ⚠️

📢 Thoughts on this report? Let us know!

@ajnavarro ajnavarro changed the title Fix: Avoid nil pointer dereferences in faucet Github fetcher fix: Avoid nil pointer dereferences in faucet Github fetcher Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status
Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants