feat(tm2/pkg): allow customizable bech32 prefix

[julienrbrt]

Allow customizable bech32 prefixes.

[Gno2D2]

🛠 PR Checks Summary

🔴 Maintainers must be able to edit this pull request (more info)

Manual Checks (for Reviewers):

• IGNORE the bot requirements for this PR (force green CI check)
• The pull request description provides enough details

Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🔴 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:

1. Fix any issues flagged by automated checks.
2. Follow the Contributor Checklist to ensure your PR is ready for review.
   • Add new tests, or document why they are unnecessary.
   • Provide clear examples/screenshots, if necessary.
   • Update documentation, if required.
   • Ensure no breaking changes, or include BREAKING CHANGE notes.
   • Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

• Report a bug with the bot.
• View the bot’s configuration file.

Debug

Automated Checks

Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: allinbits/gno)

Then

🔴 Requirement not satisfied
└── 🔴 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 User notJoon already reviewed PR 4873 with state APPROVED
    │       ├── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks

**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

• Any user with comment edit permission

The pull request description provides enough details

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)
    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])

Can be checked by

• team core-contributors

[codecov]

Codecov Report

❌ Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
tm2/pkg/crypto/crypto.go	0.00%	1 Missing and 1 partial ⚠️
contribs/gnokms/internal/common/auth_keys_file.go	0.00%	0 Missing and 1 partial ⚠️
tm2/pkg/crypto/ledger/ledger_secp256k1.go	0.00%	1 Missing ⚠️
tm2/pkg/p2p/types/key.go	0.00%	0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

[notJoon]

Could you please check the CI failures so we can proceed to the next step? Thank you

[julienrbrt]

Could you please check the CI failures so we can proceed to the next step? Thank you

done @notJoon

[notJoon]

The changes look good. I remember there was a related discussion in PR #4008, and this appears to be policy-related, it would be better to handle the details in the next step.

Additionally, how about adding a test case that uses IsValid for addresses with custom prefixes?

[julienrbrt]

Additionally, how about adding a test case that uses IsValid for addresses with custom prefixes?

We could, but that is somewhat annoying because if you modify the prefix it modifies is across all tests.
So this test would need to run alone in a different go test.