Skip to content

Conversation

@Ivorforce
Copy link
Member

This PR takes a different, more practical approach to the "general guidelines". It's structured by "Things you must do when contributing to Godot".

In contrast to #19, the AI subsection is short, and focused on disclosing the use of AI. In addition, a separate section is added about understanding what you contribute (plus another one for licenses).

After looking at both, I prefer this PR over #19.

@Ivorforce Ivorforce requested a review from a team November 9, 2025 11:43
@Ivorforce Ivorforce added the content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features label Nov 9, 2025
@Ivorforce Ivorforce force-pushed the general-guidelines-v2 branch 8 times, most recently from 580e73f to 979c7c9 Compare November 9, 2025 12:36

Contributions made entirely by AI are prohibited.

.. note:: When this page refers to "AI" it means any LLM/generative
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be ideal to shift this note way up because AI is hinted at way sooner than this section, but I am not sure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I shifted it up a tad.
I find these info boxes can impact the reading flow, so I usually keep them out of the way more often than I keep them relevant. But after the second paragraph there's a spot that has a natural break, so I'm ok with that one too.

@Ivorforce Ivorforce force-pushed the general-guidelines-v2 branch from 979c7c9 to 822a597 Compare November 9, 2025 14:10
@Ivorforce Ivorforce force-pushed the general-guidelines-v2 branch from 822a597 to 24431d4 Compare November 10, 2025 11:20
@Ivorforce Ivorforce force-pushed the general-guidelines-v2 branch 2 times, most recently from b7688b1 to 4c43879 Compare November 10, 2025 13:39
If you authored every part of your contribution, this is not a problem. You can submit your contribution
without reading further.

However, any code, images, or ideas you took from somewhere else have a copyright you must respect.
Copy link
Member

@Calinou Calinou Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideas aren't subject to copyright (or even patents). Only an implementation of something can be subject to either copyright or patents.

Suggested change
However, any code, images, or ideas you took from somewhere else have a copyright you must respect.
However, any code or assets you took from somewhere else have a copyright you must respect.

While on the topic of patents, it's possible that they can get in the way of some contributions, but it's been very uncommon in Godot's history. Therefore, it's probably not worth detailing on this page.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This used to say "intellectual property" which certainly does apply to ideas separate from the implementation. We can't implement an algorithm if it's proprietary, even if we don't use the same implementation. Maybe we should rephrase again?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should rephrase again?

Yes, but I'm not sure how to phrase it exactly. If we don't find a better alternative, it's fine to leave as-is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed a new version that's probably more correct. I'll ask in 'general' though, perhaps somebody has a stronger opinion.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall.

@Ivorforce Ivorforce force-pushed the general-guidelines-v2 branch from 4c43879 to 29203c3 Compare November 11, 2025 12:19
@Ivorforce Ivorforce force-pushed the general-guidelines-v2 branch from 29203c3 to b6b8f06 Compare November 11, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants