-
-
Notifications
You must be signed in to change notification settings - Fork 11
Add a page for general contribution guidelines. #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
580e73f to
979c7c9
Compare
|
|
||
| Contributions made entirely by AI are prohibited. | ||
|
|
||
| .. note:: When this page refers to "AI" it means any LLM/generative |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be ideal to shift this note way up because AI is hinted at way sooner than this section, but I am not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I shifted it up a tad.
I find these info boxes can impact the reading flow, so I usually keep them out of the way more often than I keep them relevant. But after the second paragraph there's a spot that has a natural break, so I'm ok with that one too.
979c7c9 to
822a597
Compare
822a597 to
24431d4
Compare
b7688b1 to
4c43879
Compare
| If you authored every part of your contribution, this is not a problem. You can submit your contribution | ||
| without reading further. | ||
|
|
||
| However, any code, images, or ideas you took from somewhere else have a copyright you must respect. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideas aren't subject to copyright (or even patents). Only an implementation of something can be subject to either copyright or patents.
| However, any code, images, or ideas you took from somewhere else have a copyright you must respect. | |
| However, any code or assets you took from somewhere else have a copyright you must respect. |
While on the topic of patents, it's possible that they can get in the way of some contributions, but it's been very uncommon in Godot's history. Therefore, it's probably not worth detailing on this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This used to say "intellectual property" which certainly does apply to ideas separate from the implementation. We can't implement an algorithm if it's proprietary, even if we don't use the same implementation. Maybe we should rephrase again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should rephrase again?
Yes, but I'm not sure how to phrase it exactly. If we don't find a better alternative, it's fine to leave as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed a new version that's probably more correct. I'll ask in 'general' though, perhaps somebody has a stronger opinion.
Calinou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall.
4c43879 to
29203c3
Compare
29203c3 to
b6b8f06
Compare
This PR takes a different, more practical approach to the "general guidelines". It's structured by "Things you must do when contributing to Godot".
In contrast to #19, the AI subsection is short, and focused on disclosing the use of AI. In addition, a separate section is added about understanding what you contribute (plus another one for licenses).
After looking at both, I prefer this PR over #19.