🐛 fix bug (#39)

Fix the sequence is always 0 for RandomSequenceResolver

Author: godruoyi

src/RandomSequenceResolver.php

@@ -48,7 +48,7 @@ public function sequence(int $currentTime)
         $this->sequence = mt_rand(0, $this->maxSequence);
         $this->lastTimeStamp = $currentTime;
 
-        return 0;
+        return $this->sequence;
     }
 
     /**

tests/BatchSnowflakeIDTest.php

@@ -0,0 +1,43 @@
+<?php
+
+/*
+ * This file is part of the godruoyi/php-snowflake.
+ *
+ * (c) Godruoyi <[email protected]>
+ *
+ * This source file is subject to the MIT license that is bundled.
+ */
+
+namespace Tests;
+
+use Godruoyi\Snowflake\Snowflake;
+
+class BatchSnowflakeIDTest extends TestCase
+{
+    public function testBatchUseSameInstance()
+    {
+        $ids = [];
+        $count = 100000;
+        $snowflake = new Snowflake();
+
+        for ($i = 0; $i < $count; $i++) {
+            $id = $snowflake->id();
+            $ids[$id] = 1;
+        }
+
+        $this->assertCount($count, $ids);
+    }
+
+    public function testBatchForDiffInstance()
+    {
+        $ids = [];
+        $count = 100000; // 10w
+
+        for ($i = 0; $i < $count; $i++) {
+            $ids[(new Snowflake())->id()] = 1;
+        }
+
+        $this->assertNotCount($count, $ids);
+        $this->assertGreaterThan(90000, count($ids));
+    }
+}

tests/DiffWorkIdBatchTest.php

@@ -20,15 +20,15 @@ public function testDissWorkID()
 
         $ids = [];
 
-        for ($i = 0; $i < 10000; ++$i) {
+        for ($i = 0; $i < 10000; $i++) {
             $id = $snowflake->id();
 
             $ids[$id] = 1;
         }
 
         $snowflake = new Snowflake(1, 2);
 
-        for ($j = 0; $j < 10000; ++$j) {
+        for ($j = 0; $j < 10000; $j++) {
             $id = $snowflake->id();
 
             $ids[$id] = 1;

tests/SnowflakeTest.php

@@ -139,7 +139,7 @@ public function testParseId()
 
         $this->assertTrue(2 === $payloads['datacenter']);
         $this->assertTrue(3 === $payloads['workerid']);
-        $this->assertTrue(0 === $payloads['sequence']);
+        $this->assertLessThan(Snowflake::MAX_SEQUENCE_SIZE, $payloads['sequence']);
 
         $payloads = $snowflake->parseId('0');
         $this->assertTrue('' == $payloads['timestamp'] || false == $payloads['timestamp']);